From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 5/7] tests/kms_fbc_crc: use igt_pipe_crc_collect_crc()
Date: Wed, 25 Mar 2015 18:50:37 -0300 [thread overview]
Message-ID: <1427320239-25667-5-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1427320239-25667-1-git-send-email-przanoni@gmail.com>
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Instead of its hardcoded implementation.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
tests/kms_fbc_crc.c | 29 +++++++----------------------
1 file changed, 7 insertions(+), 22 deletions(-)
diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c
index d81f4a2..f1888c4 100644
--- a/tests/kms_fbc_crc.c
+++ b/tests/kms_fbc_crc.c
@@ -215,7 +215,7 @@ static void test_crc(data_t *data, enum test_mode mode)
{
uint32_t crtc_id = data->output->config.crtc->crtc_id;
igt_pipe_crc_t *pipe_crc = data->pipe_crc;
- igt_crc_t *crcs = NULL;
+ igt_crc_t crc;
uint32_t handle = data->handle[0];
igt_assert(fbc_enabled(data));
@@ -271,14 +271,11 @@ static void test_crc(data_t *data, enum test_mode mode)
igt_wait_for_vblank(data->drm_fd, data->pipe);
igt_wait_for_vblank(data->drm_fd, data->pipe);
- igt_pipe_crc_start(pipe_crc);
- igt_pipe_crc_get_crcs(pipe_crc, 1, &crcs);
- igt_pipe_crc_stop(pipe_crc);
+ igt_pipe_crc_collect_crc(pipe_crc, &crc);
if (mode == TEST_PAGE_FLIP)
- igt_assert_crc_equal(&crcs[0], &data->ref_crc[1]);
+ igt_assert_crc_equal(&crc, &data->ref_crc[1]);
else
;/* FIXME: missing reference CRCs */
- free(crcs);
/*
* Allow time for FBC to kick in again if it
@@ -286,14 +283,11 @@ static void test_crc(data_t *data, enum test_mode mode)
*/
igt_assert(wait_for_fbc_enabled(data));
- igt_pipe_crc_start(pipe_crc);
- igt_pipe_crc_get_crcs(pipe_crc, 1, &crcs);
- igt_pipe_crc_stop(pipe_crc);
+ igt_pipe_crc_collect_crc(pipe_crc, &crc);
if (mode == TEST_PAGE_FLIP)
- igt_assert_crc_equal(&crcs[0], &data->ref_crc[1]);
+ igt_assert_crc_equal(&crc, &data->ref_crc[1]);
else
;/* FIXME: missing reference CRCs */
- free(crcs);
}
static bool prepare_crtc(data_t *data)
@@ -320,7 +314,6 @@ static bool prepare_test(data_t *data, enum test_mode test_mode)
igt_output_t *output = data->output;
drmModeModeInfo *mode;
igt_pipe_crc_t *pipe_crc;
- igt_crc_t *crcs = NULL;
data->primary = igt_output_get_plane(data->output, IGT_PLANE_PRIMARY);
mode = igt_output_get_mode(data->output);
@@ -367,11 +360,7 @@ static bool prepare_test(data_t *data, enum test_mode test_mode)
igt_wait_for_vblank(data->drm_fd, data->pipe);
/* get reference crc for fb[1] */
- igt_pipe_crc_start(pipe_crc);
- igt_pipe_crc_get_crcs(pipe_crc, 1, &crcs);
- data->ref_crc[1] = crcs[0];
- igt_pipe_crc_stop(pipe_crc);
- free(crcs);
+ igt_pipe_crc_collect_crc(pipe_crc, &data->ref_crc[1]);
if (test_mode == TEST_CONTEXT || test_mode == TEST_PAGE_FLIP_AND_CONTEXT) {
data->ctx[0] = drm_intel_gem_context_create(data->bufmgr);
@@ -406,11 +395,7 @@ static bool prepare_test(data_t *data, enum test_mode test_mode)
igt_wait_for_vblank(data->drm_fd, data->pipe);
/* get reference crc for fb[0] */
- igt_pipe_crc_start(pipe_crc);
- igt_pipe_crc_get_crcs(pipe_crc, 1, &crcs);
- data->ref_crc[0] = crcs[0];
- igt_pipe_crc_stop(pipe_crc);
- free(crcs);
+ igt_pipe_crc_collect_crc(pipe_crc, &data->ref_crc[0]);
return true;
}
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-25 21:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 21:50 [PATCH 1/7] lib: add igt_wait() Paulo Zanoni
2015-03-25 21:50 ` [PATCH 2/7] tests/kms_fb_crc: call gem_sync() instead of gem_bo_busy() Paulo Zanoni
2015-03-26 10:06 ` Daniel Vetter
2015-03-25 21:50 ` [PATCH 3/7] tests/kms_fbc_crc: add wait_for_fbc_enabled() Paulo Zanoni
2015-03-26 10:07 ` Daniel Vetter
2015-03-25 21:50 ` [PATCH 4/7] tests/kms_fbc_crc: also gem_sync() on exec_nop() Paulo Zanoni
2015-03-25 21:50 ` Paulo Zanoni [this message]
2015-03-25 21:50 ` [PATCH 6/7] tests/kms_fbc_crc: remove redundant information from data_t Paulo Zanoni
2015-03-25 21:50 ` [PATCH 7/7] lib: add igt_draw Paulo Zanoni
2015-03-26 10:19 ` Daniel Vetter
2015-03-30 19:45 ` Paulo Zanoni
2015-03-31 13:07 ` Daniel Vetter
2015-03-31 14:03 ` Paulo Zanoni
2015-03-31 21:52 ` Paulo Zanoni
2015-03-31 22:05 ` Chris Wilson
2015-04-01 22:08 ` Paulo Zanoni
2015-04-01 22:22 ` Chris Wilson
2015-04-01 22:33 ` Paulo Zanoni
2015-04-01 22:40 ` Paulo Zanoni
2015-04-01 23:15 ` Chris Wilson
2015-04-01 23:17 ` Chris Wilson
2015-04-07 8:10 ` Daniel Vetter
2015-04-07 8:36 ` Chris Wilson
2015-04-07 9:07 ` Daniel Vetter
2015-04-07 10:12 ` Chris Wilson
2015-04-07 13:44 ` Daniel Vetter
2015-05-05 21:30 ` Paulo Zanoni
2015-05-06 9:00 ` Daniel Vetter
2015-04-01 23:03 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427320239-25667-5-git-send-email-przanoni@gmail.com \
--to=przanoni@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.