From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 3/7] libxl: In libxl_set_vcpuonline check
 for maximum number of VCPUs against the cpumap.
Date: Thu, 26 Mar 2015 10:00:18 +0000
Message-ID: <1427364018.10784.115.camel@citrix.com>
References: <1427134861-18881-1-git-send-email-konrad.wilk@oracle.com>
	<1427134861-18881-4-git-send-email-konrad.wilk@oracle.com>
	<1427210575.21742.438.camel@citrix.com>
	<20150325184415.GB27691@l.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Yb4da-0005SF-Sf
	for xen-devel@lists.xenproject.org; Thu, 26 Mar 2015 10:03:43 +0000
In-Reply-To: <20150325184415.GB27691@l.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ian.Jackson@eu.citrix.com, dario.faggioli@citrix.com, wei.liu2@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-03-25 at 14:44 -0400, Konrad Rzeszutek Wilk wrote:

> +    if (type == LIBXL_DOMAIN_TYPE_HVM || type == LIBXL_DOMAIN_TYPE_PV) {

I think just do the libxl_domain_info unconditionally and handle the
error if it doesn't work.

Otherwise looked good, but please try and const-ify the info parameter.

Ian.