From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH 3/3] xen: arm: handle thumb mode guest in continuations
Date: Thu, 26 Mar 2015 10:06:10 +0000 [thread overview]
Message-ID: <1427364370.10784.121.camel@citrix.com> (raw)
In-Reply-To: <551345AD.5020608@linaro.org>
On Wed, 2015-03-25 at 23:33 +0000, Julien Grall wrote:
> Hi Ian,
>
> On 25/03/2015 15:34, Ian Campbell wrote:
> > PC only needs adjusting by 2, otherwise we rerun the instruction prior
> > to the hvc as well.
>
> I don't understand why you have to adjust PC by 2 for thumb.
> The spec encodes the HVC thumb instruction on 32 bits (i.e 4 bytes).
I was confused by Encoding T1 in the ARMv7 ARM B9.3.4 which has a 15 at
the left most column, but actually it is 15..0,15..0, doh!
So we are fine here. I'll drop this patch and pull the regs->pc frobbing
in the previous patch back out of the if into the common bit.
Ian.
prev parent reply other threads:[~2015-03-26 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 15:34 [PATCH 3/3] xen: arm: handle thumb mode guest in continuations Ian Campbell
2015-03-25 23:33 ` Julien Grall
2015-03-26 10:06 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427364370.10784.121.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.