From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 02/12] xen: arm: handle accesses to
 CNTP_CVAL_EL0
Date: Thu, 26 Mar 2015 16:07:42 +0000
Message-ID: <1427386062.13935.62.camel@citrix.com>
References: <1427293339.10784.83.camel@citrix.com>
	<1427293356-5714-2-git-send-email-ian.campbell@citrix.com>
	<5512FF3C.2070109@linaro.org> <1427367587.13935.14.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1427367587.13935.14.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xen.org, tim@xen.org, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-03-26 at 10:59 +0000, Ian Campbell wrote:
> On Wed, 2015-03-25 at 18:32 +0000, Julien Grall wrote:
> > On 25/03/15 14:22, Ian Campbell wrote:
> > > +static int vtimer_cntp_cval(struct cpu_user_regs *regs, uint64_t *r, int read)
> > > +{
> > > +    struct vcpu *v = current;
> > > +
> > > +    if ( psr_mode_is_user(regs) &&
> > > +         !(READ_SYSREG(CNTKCTL_EL1) & CNTKCTL_EL1_EL0PTEN) )
> > 
> > Sorry, I didn't notice it on my previous review.
> > 
> > CNTKCTL_EL1_EL0PTEN and psr_mode_is_user are only defined in
> > respectively patch #6 and #4.
> 
> Well spotted.
> 
> > Can you invert the patches to avoid build breakage during bisection?
> 
> I was hoping to be able to backport this, so I think I will move the
> definitions of CNTKCTL_* here and either decide to backport the psr_mdoe
> refactoring or see if I can avoid using it in this patch.

In the end #6 (xen: arm: correctly handle vtimer traps from userspace)
should probably be backported too and the psr_mode_is_user one is simple
enough it's easiest to just take it as a precursor.

So I've reordered.

Ian.