From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jaggi, Manish" Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain Date: Fri, 27 Mar 2015 13:26:04 +0000 Message-ID: <1427462781997.9237@caviumnetworks.com> References: <551505B3.9020505@caviumnetworks.com>, <55155557.7020103@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55155557.7020103@linaro.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , Xen Devel , "Prasun.kapoor@cavium.com" , "Kumar, Vijaya" , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Regards, Manish Jaggi ________________________________________ From: Julien Grall Sent: Friday, March 27, 2015 6:34 PM To: Jaggi, Manish; Xen Devel; Prasun.kapoor@cavium.com; Kumar, Vijaya; Ian Campbell; Stefano Stabellini Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain Hi manish, On 27/03/15 07:24, Manish Jaggi wrote: > It is good for code readability as there are many structures ending with > the name domain. > Also a code like this one is now easy to understand with the rename > old: dev_iommu_domain(dev) = domain; > new: dev_iommu_domain(dev) = iommu_domain; [manish] Did u see this line > > Also in current code struct smmu_domain pointer variable name is always > smmu_domain. > The change is on the same lines You are modifying the code from Linux just for your own comprehension. And we are trying to not diverge from a specific Linux commit in order to easily backport patch. [manish] please rethink on nack. There are so many data structures ending in _domain we need to provide proper naming. NAcked-by: Julien Grall Regards, -- Julien Grall