All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [PATCH] tvp5150: Fix device ID kernel log message
Date: Thu, 17 Jul 2014 13:29:51 +0200	[thread overview]
Message-ID: <1427497.bCxcs01A7z@avalon> (raw)
In-Reply-To: <1401132511-5236-1-git-send-email-laurent.pinchart@ideasonboard.com>

Hi Mauro,

Ping ?

On Monday 26 May 2014 21:28:31 Laurent Pinchart wrote:
> The driver mistakenly prints the ROM version instead of the device ID to
> the kernel log when detecting the chip. Fix it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  drivers/media/i2c/tvp5150.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index a912125..937e48b 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -1148,10 +1148,10 @@ static int tvp5150_probe(struct i2c_client *c,
>  		/* Is TVP5150A */
>  		if (tvp5150_id[2] == 3 || tvp5150_id[3] == 0x21) {
>  			v4l2_info(sd, "tvp%02x%02xa detected.\n",
> -				  tvp5150_id[2], tvp5150_id[3]);
> +				  tvp5150_id[0], tvp5150_id[1]);
>  		} else {
>  			v4l2_info(sd, "*** unknown tvp%02x%02x chip detected.\n",
> -				  tvp5150_id[2], tvp5150_id[3]);
> +				  tvp5150_id[0], tvp5150_id[1]);
>  			v4l2_info(sd, "*** Rom ver is %d.%d\n",
>  				  tvp5150_id[2], tvp5150_id[3]);
>  		}

-- 
Regards,

Laurent Pinchart


      reply	other threads:[~2014-07-17 11:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26 19:28 [PATCH] tvp5150: Fix device ID kernel log message Laurent Pinchart
2014-07-17 11:29 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427497.bCxcs01A7z@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.