From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752801AbbC2XOI (ORCPT <rfc822;w@1wt.eu>);
	Sun, 29 Mar 2015 19:14:08 -0400
Received: from smtprelay0180.hostedemail.com ([216.40.44.180]:46131 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752631AbbC2XOD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 29 Mar 2015 19:14:03 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:4321:4605:5007:6261:7904:7974:8957:10004:10400:10848:11026:11232:11233:11658:11914:12043:12114:12438:12517:12519:12740:13069:13071:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: pin72_7a522cd78c307
X-Filterd-Recvd-Size: 2226
Message-ID: <1427670839.2715.44.camel@perches.com>
Subject: Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of
 rtllib_rx_auth_resp()
From: Joe Perches <joe@perches.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Sun, 29 Mar 2015 16:13:59 -0700
In-Reply-To: <1427668867-10906-11-git-send-email-mateusz.kulikowski@gmail.com>
References: <1427668867-10906-1-git-send-email-mateusz.kulikowski@gmail.com>
	 <1427668867-10906-11-git-send-email-mateusz.kulikowski@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote:
> Return from rtllib_rx_auth_resp() if auth_parse() fails.

Hello Mateusz.  Here are some trivial notes.

> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
[]
> +		/* Dummy wirless mode setting to avoid
> +		 * encryption issue */

Please use the typical networking comment style
(and correct the typo too)

		/* Dummy wireless mode setting to avoid
		 * encryption issue
		 */

> +		if (bSupportNmode) {
> +			ieee->SetWirelessMode(ieee->dev,
> +			   ieee->current_network.mode);
> +		} else {
> +			/*TODO*/
> +			ieee->SetWirelessMode(ieee->dev,
> +					      IEEE_G);

Many of these multiple line statements can be single line.

> +		}
> +
> +		if (ieee->current_network.mode ==
> +		    IEEE_N_24G && bHalfSupportNmode) {
> +			netdev_info(ieee->dev,
> +				    "======>enter half N mode\n");
> +			ieee->bHalfWirelessN24GMode =
> +						 true;
> +		} else
> +			ieee->bHalfWirelessN24GMode =
> +						 false;

Single line and better with braces.

> +
> +		rtllib_associate_step2(ieee);
> +	} else {
> +		rtllib_auth_challenge(ieee, challenge,
> +				      chlen);
>  	}
>  }

Single line.