From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 36EE56013D for ; Mon, 30 Mar 2015 09:20:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t2U9KJ2H026997; Mon, 30 Mar 2015 10:20:19 +0100 Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DutFqgQWrWri; Mon, 30 Mar 2015 10:20:19 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t2U9K75J026986 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 30 Mar 2015 10:20:18 +0100 Message-ID: <1427707207.14020.249.camel@linuxfoundation.org> From: Richard Purdie To: ed.bartosh@linux.intel.com Date: Mon, 30 Mar 2015 10:20:07 +0100 In-Reply-To: <20150330091715.GA2050@linux.intel.com> References: <1427706018-1695-1-git-send-email-ed.bartosh@linux.intel.com> <1427706673.14020.246.camel@linuxfoundation.org> <20150330091715.GA2050@linux.intel.com> X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] package_manager: Run createrepo sequentially X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 09:20:22 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2015-03-30 at 12:17 +0300, Ed Bartosh wrote: > On Mon, Mar 30, 2015 at 10:11:13AM +0100, Richard Purdie wrote: > > On Mon, 2015-03-30 at 12:00 +0300, Ed Bartosh wrote: > > > Running multiple createrepo in parallel can cause raice conditions > > > when creating/accessing rpm database. Createrepo fails with the > > > error "package_manager: rpmdb: BDB0060 PANIC: fatal region error detected" > > > in such cases. > > > > > > Running createrepo sequentially should fix the race as rpm database > > > will not be accessed by multiple createrepo at the same time. > > > > > > [YOCTO #6571] > > > > > > Signed-off-by: Ed Bartosh > > > --- > > > meta/lib/oe/package_manager.py | 11 ++++------- > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py > > > index c9a8084..c956116 100644 > > > --- a/meta/lib/oe/package_manager.py > > > +++ b/meta/lib/oe/package_manager.py > > > @@ -108,25 +108,22 @@ class RpmIndexer(Indexer): > > > archs = archs.union(set(sdk_pkg_archs)) > > > > > > rpm_createrepo = bb.utils.which(os.getenv('PATH'), "createrepo") > > > - index_cmds = [] > > > rpm_dirs_found = False > > > for arch in archs: > > > arch_dir = os.path.join(self.deploy_dir, arch) > > > if not os.path.isdir(arch_dir): > > > continue > > > > > > - index_cmds.append("%s --update -q %s" % (rpm_createrepo, arch_dir)) > > > - > > > rpm_dirs_found = True > > > > > > + result = create_index("%s --update -q %s" % (rpm_createrepo, arch_dir)) > > > + if result: > > > + bb.fatal(result) > > > + > > > if not rpm_dirs_found: > > > bb.note("There are no packages in %s" % self.deploy_dir) > > > return > > > > > > - result = oe.utils.multiprocess_exec(index_cmds, create_index) > > > - if result: > > > - bb.fatal('%s' % ('\n'.join(result))) > > > - > > > > > > class OpkgIndexer(Indexer): > > > def write_index(self): > > > > Running these in parallel gives us a significant speed improvement. > > Could we instead point them at separate directories for the RPM database > > (within WORKDIR to address the previous issue too)? > > > I didn't see any noticeable performance gain at least for minimal image. I measured the time of > bitbake build before and after this change. It was practically the same. For minimal, no, you wouldn't. For something like meta-toolchain-sdk there are multiple large package feeds and it should show more of a change. The best benchmark for this is: "time bitbake package-index" having cleaned out the indexes from the package feeds by hand (having built a large feed such as sdk images). Cheers, Richard