From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V14 5/7] xen/arm: Instruction prefetch abort
 (X) mem_access event handling
Date: Mon, 30 Mar 2015 10:41:22 +0100
Message-ID: <1427708482.13935.252.camel@citrix.com>
References: <1427407531-31694-1-git-send-email-tklengyel@sec.in.tum.de>
	<1427407531-31694-6-git-send-email-tklengyel@sec.in.tum.de>
	<1427471569.13935.177.camel@citrix.com>
	<CABfawhmLSz-sC4-dUFgsaVvJewPrw-Rt-e-8uDsmhZLb-qhjiw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CABfawhmLSz-sC4-dUFgsaVvJewPrw-Rt-e-8uDsmhZLb-qhjiw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>
Cc: "wei.liu2@citrix.com" <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Julien Grall <julien.grall@linaro.org>, Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-03-27 at 22:18 +0000, Tamas K Lengyel wrote:

>         
>         >                                        union hsr hsr)
>         >  {
>         > -    register_t addr = READ_SYSREG(FAR_EL2);
>         > -    inject_iabt_exception(regs, addr, hsr.len);
>         > +    struct hsr_iabt iabt = hsr.iabt;
>         > +    int rc;
>         > +    paddr_t gpa;
>         > +    register_t gva = READ_SYSREG(FAR_EL2);
>         > +
>         > +    if ( iabt.s1ptw )
>         > +        gpa = READ_SYSREG(HPFAR_EL2);
>         > +    else
>         
>         
>         Can you not avoid the else case entirely by extending the if to cover
>         the other cases where HPFAR is explicitly valid? I can't be bothered to
>         go look right now but IIRC it included at least stage 2 access
>         permissions related failures, which would cover more xenaccess
>         scenarios, no?
> 
> 
> Depending on the fault cause, we might. For permission faults, HPFAR
> is only valid during s1ptw.. Given that the only check we do is for
> permission faults and that's the only thing that cares about the API
> anyway, we can put this entire block into the switch itself once the
> fault check is already determined to be a permission fault.

According to ARMv8 ARM HPFAR is valid for any of these:
      * A Translation or Access Flag fault on a stage 2 translation.
      * A stage 2 Address Size fault.
      * A fault on the stage 2 translation of an address accessed in a
        stage 1 translation table walk.

I think what you are (correctly) saying is that it omits "a permission
fault on a stage 2 translation", which is one of the cases which can
occur under xenaccess. Which is shame :-(

Ian.