diff for duplicates of <1427712943.20500.77.camel@kernel.crashing.org> diff --git a/a/1.txt b/N1/1.txt index acfd259..1464d3d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -47,8 +47,8 @@ Those are just "pools", it's sufficient. > Ok. > > > > + /* Sanity check */ -> > > + if (unlikely(npages == 0)) { -> > > + printk_ratelimited("npages == 0\n"); +> > > + if (unlikely(npages = 0)) { +> > > + printk_ratelimited("npages = 0\n"); > > > > You removed the WARN_ON here which had the nice property of giving you a > > backtrace which points to the offender. The above message alone is @@ -60,7 +60,7 @@ Those are just "pools", it's sufficient. Put it back please, and ignore checkpatch, it's become an annoyance more than anything else. -Note that nowadays, you can probably use WARN_ON_ONCE(npages == 0); in +Note that nowadays, you can probably use WARN_ON_ONCE(npages = 0); in place of the whole construct. > > I am not certain about the "first unlocked pool"... We take the lock for diff --git a/a/content_digest b/N1/content_digest index 609c561..073d541 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,8 +3,8 @@ "ref\01427685844.20500.66.camel@kernel.crashing.org\0" "ref\020150330103824.GA26127@oracle.com\0" "From\0Benjamin Herrenschmidt <benh@kernel.crashing.org>\0" - "Subject\0Re: [PATCH v7 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock\0" - "Date\0Mon, 30 Mar 2015 21:55:43 +1100\0" + "Subject\0Re: [PATCH v7 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l\0" + "Date\0Mon, 30 Mar 2015 10:55:43 +0000\0" "To\0Sowmini Varadhan <sowmini.varadhan@oracle.com>\0" "Cc\0aik@au1.ibm.com" anton@au1.ibm.com @@ -63,8 +63,8 @@ "> Ok.\n" "> \n" "> > > +\t/* Sanity check */\n" - "> > > +\tif (unlikely(npages == 0)) {\n" - "> > > +\t\tprintk_ratelimited(\"npages == 0\\n\");\n" + "> > > +\tif (unlikely(npages = 0)) {\n" + "> > > +\t\tprintk_ratelimited(\"npages = 0\\n\");\n" "> > \n" "> > You removed the WARN_ON here which had the nice property of giving you a\n" "> > backtrace which points to the offender. The above message alone is\n" @@ -76,7 +76,7 @@ "Put it back please, and ignore checkpatch, it's become an annoyance more\n" "than anything else.\n" "\n" - "Note that nowadays, you can probably use WARN_ON_ONCE(npages == 0); in\n" + "Note that nowadays, you can probably use WARN_ON_ONCE(npages = 0); in\n" "place of the whole construct.\n" "\n" "> > I am not certain about the \"first unlocked pool\"... We take the lock for\n" @@ -115,4 +115,4 @@ "Cheers,\n" Ben. -897aa421e4a189a576791e7b61f6a76d91631623315624013c40fb39dc7e4918 +1c67fdaa7906a3c8875a90863966c4618485a649b60471470507099a1ea270c6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.