From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Tue, 31 Mar 2015 01:49:09 +0000 Subject: Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0 Message-Id: <1427766549.20500.108.camel@kernel.crashing.org> List-Id: References: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> In-Reply-To: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: linux-kernel@vger.kernel.org, Alexander Graf , Gleb Natapov , Paolo Bonzini , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote: > Use the normal return values for bool functions Acked-by: Benjamin Herrenschmidt Should we merge it or will you ? Cheers, Ben. > Signed-off-by: Joe Perches > --- > arch/powerpc/include/asm/dcr-native.h | 2 +- > arch/powerpc/include/asm/dma-mapping.h | 4 ++-- > arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++-- > arch/powerpc/sysdev/dcr.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/include/asm/dcr-native.h b/arch/powerpc/include/asm/dcr-native.h > index 7d2e623..4efc11d 100644 > --- a/arch/powerpc/include/asm/dcr-native.h > +++ b/arch/powerpc/include/asm/dcr-native.h > @@ -31,7 +31,7 @@ typedef struct { > > static inline bool dcr_map_ok_native(dcr_host_native_t host) > { > - return 1; > + return true; > } > > #define dcr_map_native(dev, dcr_n, dcr_c) \ > diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h > index 894d538..9103687 100644 > --- a/arch/powerpc/include/asm/dma-mapping.h > +++ b/arch/powerpc/include/asm/dma-mapping.h > @@ -191,11 +191,11 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) > struct dev_archdata *sd = &dev->archdata; > > if (sd->max_direct_dma_addr && addr + size > sd->max_direct_dma_addr) > - return 0; > + return false; > #endif > > if (!dev->dma_mask) > - return 0; > + return false; > > return addr + size - 1 <= *dev->dma_mask; > } > diff --git a/arch/powerpc/include/asm/kvm_book3s_64.h b/arch/powerpc/include/asm/kvm_book3s_64.h > index 2d81e20..2a244bf 100644 > --- a/arch/powerpc/include/asm/kvm_book3s_64.h > +++ b/arch/powerpc/include/asm/kvm_book3s_64.h > @@ -335,7 +335,7 @@ static inline bool hpte_read_permission(unsigned long pp, unsigned long key) > { > if (key) > return PP_RWRX <= pp && pp <= PP_RXRX; > - return 1; > + return true; > } > > static inline bool hpte_write_permission(unsigned long pp, unsigned long key) > @@ -373,7 +373,7 @@ static inline bool slot_is_aligned(struct kvm_memory_slot *memslot, > unsigned long mask = (pagesize >> PAGE_SHIFT) - 1; > > if (pagesize <= PAGE_SIZE) > - return 1; > + return true; > return !(memslot->base_gfn & mask) && !(memslot->npages & mask); > } > > diff --git a/arch/powerpc/sysdev/dcr.c b/arch/powerpc/sysdev/dcr.c > index 2d8a101..121e26f 100644 > --- a/arch/powerpc/sysdev/dcr.c > +++ b/arch/powerpc/sysdev/dcr.c > @@ -54,7 +54,7 @@ bool dcr_map_ok_generic(dcr_host_t host) > else if (host.type = DCR_HOST_MMIO) > return dcr_map_ok_mmio(host.host.mmio); > else > - return 0; > + return false; > } > EXPORT_SYMBOL_GPL(dcr_map_ok_generic); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 1BCE41A005A for ; Tue, 31 Mar 2015 12:49:37 +1100 (AEDT) Message-ID: <1427766549.20500.108.camel@kernel.crashing.org> Subject: Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0 From: Benjamin Herrenschmidt To: Joe Perches Date: Tue, 31 Mar 2015 12:49:09 +1100 In-Reply-To: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> References: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Alexander Graf , Paul Mackerras , Paolo Bonzini , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote: > Use the normal return values for bool functions Acked-by: Benjamin Herrenschmidt Should we merge it or will you ? Cheers, Ben. > Signed-off-by: Joe Perches > --- > arch/powerpc/include/asm/dcr-native.h | 2 +- > arch/powerpc/include/asm/dma-mapping.h | 4 ++-- > arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++-- > arch/powerpc/sysdev/dcr.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/include/asm/dcr-native.h b/arch/powerpc/include/asm/dcr-native.h > index 7d2e623..4efc11d 100644 > --- a/arch/powerpc/include/asm/dcr-native.h > +++ b/arch/powerpc/include/asm/dcr-native.h > @@ -31,7 +31,7 @@ typedef struct { > > static inline bool dcr_map_ok_native(dcr_host_native_t host) > { > - return 1; > + return true; > } > > #define dcr_map_native(dev, dcr_n, dcr_c) \ > diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h > index 894d538..9103687 100644 > --- a/arch/powerpc/include/asm/dma-mapping.h > +++ b/arch/powerpc/include/asm/dma-mapping.h > @@ -191,11 +191,11 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) > struct dev_archdata *sd = &dev->archdata; > > if (sd->max_direct_dma_addr && addr + size > sd->max_direct_dma_addr) > - return 0; > + return false; > #endif > > if (!dev->dma_mask) > - return 0; > + return false; > > return addr + size - 1 <= *dev->dma_mask; > } > diff --git a/arch/powerpc/include/asm/kvm_book3s_64.h b/arch/powerpc/include/asm/kvm_book3s_64.h > index 2d81e20..2a244bf 100644 > --- a/arch/powerpc/include/asm/kvm_book3s_64.h > +++ b/arch/powerpc/include/asm/kvm_book3s_64.h > @@ -335,7 +335,7 @@ static inline bool hpte_read_permission(unsigned long pp, unsigned long key) > { > if (key) > return PP_RWRX <= pp && pp <= PP_RXRX; > - return 1; > + return true; > } > > static inline bool hpte_write_permission(unsigned long pp, unsigned long key) > @@ -373,7 +373,7 @@ static inline bool slot_is_aligned(struct kvm_memory_slot *memslot, > unsigned long mask = (pagesize >> PAGE_SHIFT) - 1; > > if (pagesize <= PAGE_SIZE) > - return 1; > + return true; > return !(memslot->base_gfn & mask) && !(memslot->npages & mask); > } > > diff --git a/arch/powerpc/sysdev/dcr.c b/arch/powerpc/sysdev/dcr.c > index 2d8a101..121e26f 100644 > --- a/arch/powerpc/sysdev/dcr.c > +++ b/arch/powerpc/sysdev/dcr.c > @@ -54,7 +54,7 @@ bool dcr_map_ok_generic(dcr_host_t host) > else if (host.type == DCR_HOST_MMIO) > return dcr_map_ok_mmio(host.host.mmio); > else > - return 0; > + return false; > } > EXPORT_SYMBOL_GPL(dcr_map_ok_generic); > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0 Date: Tue, 31 Mar 2015 12:49:09 +1100 Message-ID: <1427766549.20500.108.camel@kernel.crashing.org> References: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Alexander Graf , Paul Mackerras , Paolo Bonzini , linuxppc-dev@lists.ozlabs.org To: Joe Perches Return-path: In-Reply-To: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org T24gTW9uLCAyMDE1LTAzLTMwIGF0IDE2OjQ2IC0wNzAwLCBKb2UgUGVyY2hlcyB3cm90ZToKPiBV c2UgdGhlIG5vcm1hbCByZXR1cm4gdmFsdWVzIGZvciBib29sIGZ1bmN0aW9ucwoKQWNrZWQtYnk6 IEJlbmphbWluIEhlcnJlbnNjaG1pZHQgPGJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZz4KClNob3Vs ZCB3ZSBtZXJnZSBpdCBvciB3aWxsIHlvdSA/CgpDaGVlcnMsCkJlbi4KCj4gU2lnbmVkLW9mZi1i eTogSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4KPiAtLS0KPiAgYXJjaC9wb3dlcnBjL2lu Y2x1ZGUvYXNtL2Rjci1uYXRpdmUuaCAgICB8IDIgKy0KPiAgYXJjaC9wb3dlcnBjL2luY2x1ZGUv YXNtL2RtYS1tYXBwaW5nLmggICB8IDQgKystLQo+ICBhcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20v a3ZtX2Jvb2szc182NC5oIHwgNCArKy0tCj4gIGFyY2gvcG93ZXJwYy9zeXNkZXYvZGNyLmMgICAg ICAgICAgICAgICAgfCAyICstCj4gIDQgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20v ZGNyLW5hdGl2ZS5oIGIvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL2Rjci1uYXRpdmUuaAo+IGlu ZGV4IDdkMmU2MjMuLjRlZmMxMWQgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9wb3dlcnBjL2luY2x1ZGUv YXNtL2Rjci1uYXRpdmUuaAo+ICsrKyBiL2FyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9kY3ItbmF0 aXZlLmgKPiBAQCAtMzEsNyArMzEsNyBAQCB0eXBlZGVmIHN0cnVjdCB7Cj4gIAo+ICBzdGF0aWMg aW5saW5lIGJvb2wgZGNyX21hcF9va19uYXRpdmUoZGNyX2hvc3RfbmF0aXZlX3QgaG9zdCkKPiAg ewo+IC0JcmV0dXJuIDE7Cj4gKwlyZXR1cm4gdHJ1ZTsKPiAgfQo+ICAKPiAgI2RlZmluZSBkY3Jf bWFwX25hdGl2ZShkZXYsIGRjcl9uLCBkY3JfYykgXAo+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2Vy cGMvaW5jbHVkZS9hc20vZG1hLW1hcHBpbmcuaCBiL2FyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9k bWEtbWFwcGluZy5oCj4gaW5kZXggODk0ZDUzOC4uOTEwMzY4NyAxMDA2NDQKPiAtLS0gYS9hcmNo L3Bvd2VycGMvaW5jbHVkZS9hc20vZG1hLW1hcHBpbmcuaAo+ICsrKyBiL2FyY2gvcG93ZXJwYy9p bmNsdWRlL2FzbS9kbWEtbWFwcGluZy5oCj4gQEAgLTE5MSwxMSArMTkxLDExIEBAIHN0YXRpYyBp bmxpbmUgYm9vbCBkbWFfY2FwYWJsZShzdHJ1Y3QgZGV2aWNlICpkZXYsIGRtYV9hZGRyX3QgYWRk ciwgc2l6ZV90IHNpemUpCj4gIAlzdHJ1Y3QgZGV2X2FyY2hkYXRhICpzZCA9ICZkZXYtPmFyY2hk YXRhOwo+ICAKPiAgCWlmIChzZC0+bWF4X2RpcmVjdF9kbWFfYWRkciAmJiBhZGRyICsgc2l6ZSA+ IHNkLT5tYXhfZGlyZWN0X2RtYV9hZGRyKQo+IC0JCXJldHVybiAwOwo+ICsJCXJldHVybiBmYWxz ZTsKPiAgI2VuZGlmCj4gIAo+ICAJaWYgKCFkZXYtPmRtYV9tYXNrKQo+IC0JCXJldHVybiAwOwo+ ICsJCXJldHVybiBmYWxzZTsKPiAgCj4gIAlyZXR1cm4gYWRkciArIHNpemUgLSAxIDw9ICpkZXYt PmRtYV9tYXNrOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9r dm1fYm9vazNzXzY0LmggYi9hcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20va3ZtX2Jvb2szc182NC5o Cj4gaW5kZXggMmQ4MWUyMC4uMmEyNDRiZiAxMDA2NDQKPiAtLS0gYS9hcmNoL3Bvd2VycGMvaW5j bHVkZS9hc20va3ZtX2Jvb2szc182NC5oCj4gKysrIGIvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNt L2t2bV9ib29rM3NfNjQuaAo+IEBAIC0zMzUsNyArMzM1LDcgQEAgc3RhdGljIGlubGluZSBib29s IGhwdGVfcmVhZF9wZXJtaXNzaW9uKHVuc2lnbmVkIGxvbmcgcHAsIHVuc2lnbmVkIGxvbmcga2V5 KQo+ICB7Cj4gIAlpZiAoa2V5KQo+ICAJCXJldHVybiBQUF9SV1JYIDw9IHBwICYmIHBwIDw9IFBQ X1JYUlg7Cj4gLQlyZXR1cm4gMTsKPiArCXJldHVybiB0cnVlOwo+ICB9Cj4gIAo+ICBzdGF0aWMg aW5saW5lIGJvb2wgaHB0ZV93cml0ZV9wZXJtaXNzaW9uKHVuc2lnbmVkIGxvbmcgcHAsIHVuc2ln bmVkIGxvbmcga2V5KQo+IEBAIC0zNzMsNyArMzczLDcgQEAgc3RhdGljIGlubGluZSBib29sIHNs b3RfaXNfYWxpZ25lZChzdHJ1Y3Qga3ZtX21lbW9yeV9zbG90ICptZW1zbG90LAo+ICAJdW5zaWdu ZWQgbG9uZyBtYXNrID0gKHBhZ2VzaXplID4+IFBBR0VfU0hJRlQpIC0gMTsKPiAgCj4gIAlpZiAo cGFnZXNpemUgPD0gUEFHRV9TSVpFKQo+IC0JCXJldHVybiAxOwo+ICsJCXJldHVybiB0cnVlOwo+ ICAJcmV0dXJuICEobWVtc2xvdC0+YmFzZV9nZm4gJiBtYXNrKSAmJiAhKG1lbXNsb3QtPm5wYWdl cyAmIG1hc2spOwo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMvc3lzZGV2L2Rj ci5jIGIvYXJjaC9wb3dlcnBjL3N5c2Rldi9kY3IuYwo+IGluZGV4IDJkOGExMDEuLjEyMWUyNmYg MTAwNjQ0Cj4gLS0tIGEvYXJjaC9wb3dlcnBjL3N5c2Rldi9kY3IuYwo+ICsrKyBiL2FyY2gvcG93 ZXJwYy9zeXNkZXYvZGNyLmMKPiBAQCAtNTQsNyArNTQsNyBAQCBib29sIGRjcl9tYXBfb2tfZ2Vu ZXJpYyhkY3JfaG9zdF90IGhvc3QpCj4gIAllbHNlIGlmIChob3N0LnR5cGUgPT0gRENSX0hPU1Rf TU1JTykKPiAgCQlyZXR1cm4gZGNyX21hcF9va19tbWlvKGhvc3QuaG9zdC5tbWlvKTsKPiAgCWVs c2UKPiAtCQlyZXR1cm4gMDsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gIH0KPiAgRVhQT1JUX1NZTUJP TF9HUEwoZGNyX21hcF9va19nZW5lcmljKTsKPiAgCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMtZGV2IG1haWxpbmcgbGlzdApMaW51eHBw Yy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8v bGludXhwcGMtZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754061AbbCaCzW (ORCPT ); Mon, 30 Mar 2015 22:55:22 -0400 Received: from gate.crashing.org ([63.228.1.57]:42580 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbbCaCzU (ORCPT ); Mon, 30 Mar 2015 22:55:20 -0400 Message-ID: <1427766549.20500.108.camel@kernel.crashing.org> Subject: Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0 From: Benjamin Herrenschmidt To: Joe Perches Cc: linux-kernel@vger.kernel.org, Alexander Graf , Gleb Natapov , Paolo Bonzini , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org Date: Tue, 31 Mar 2015 12:49:09 +1100 In-Reply-To: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> References: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote: > Use the normal return values for bool functions Acked-by: Benjamin Herrenschmidt Should we merge it or will you ? Cheers, Ben. > Signed-off-by: Joe Perches > --- > arch/powerpc/include/asm/dcr-native.h | 2 +- > arch/powerpc/include/asm/dma-mapping.h | 4 ++-- > arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++-- > arch/powerpc/sysdev/dcr.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/include/asm/dcr-native.h b/arch/powerpc/include/asm/dcr-native.h > index 7d2e623..4efc11d 100644 > --- a/arch/powerpc/include/asm/dcr-native.h > +++ b/arch/powerpc/include/asm/dcr-native.h > @@ -31,7 +31,7 @@ typedef struct { > > static inline bool dcr_map_ok_native(dcr_host_native_t host) > { > - return 1; > + return true; > } > > #define dcr_map_native(dev, dcr_n, dcr_c) \ > diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h > index 894d538..9103687 100644 > --- a/arch/powerpc/include/asm/dma-mapping.h > +++ b/arch/powerpc/include/asm/dma-mapping.h > @@ -191,11 +191,11 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) > struct dev_archdata *sd = &dev->archdata; > > if (sd->max_direct_dma_addr && addr + size > sd->max_direct_dma_addr) > - return 0; > + return false; > #endif > > if (!dev->dma_mask) > - return 0; > + return false; > > return addr + size - 1 <= *dev->dma_mask; > } > diff --git a/arch/powerpc/include/asm/kvm_book3s_64.h b/arch/powerpc/include/asm/kvm_book3s_64.h > index 2d81e20..2a244bf 100644 > --- a/arch/powerpc/include/asm/kvm_book3s_64.h > +++ b/arch/powerpc/include/asm/kvm_book3s_64.h > @@ -335,7 +335,7 @@ static inline bool hpte_read_permission(unsigned long pp, unsigned long key) > { > if (key) > return PP_RWRX <= pp && pp <= PP_RXRX; > - return 1; > + return true; > } > > static inline bool hpte_write_permission(unsigned long pp, unsigned long key) > @@ -373,7 +373,7 @@ static inline bool slot_is_aligned(struct kvm_memory_slot *memslot, > unsigned long mask = (pagesize >> PAGE_SHIFT) - 1; > > if (pagesize <= PAGE_SIZE) > - return 1; > + return true; > return !(memslot->base_gfn & mask) && !(memslot->npages & mask); > } > > diff --git a/arch/powerpc/sysdev/dcr.c b/arch/powerpc/sysdev/dcr.c > index 2d8a101..121e26f 100644 > --- a/arch/powerpc/sysdev/dcr.c > +++ b/arch/powerpc/sysdev/dcr.c > @@ -54,7 +54,7 @@ bool dcr_map_ok_generic(dcr_host_t host) > else if (host.type == DCR_HOST_MMIO) > return dcr_map_ok_mmio(host.host.mmio); > else > - return 0; > + return false; > } > EXPORT_SYMBOL_GPL(dcr_map_ok_generic); >