From: Huang Ying <ying.huang@intel.com>
To: lkp@lists.01.org
Subject: Re: [Btrfs] 3a8b36f3780: -62.6% fileio.requests_per_sec
Date: Tue, 31 Mar 2015 16:32:47 +0800 [thread overview]
Message-ID: <1427790767.17170.95.camel@intel.com> (raw)
In-Reply-To: <55094E06.2070004@suse.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
Hi, Filipe,
On Wed, 2015-03-18 at 10:05 +0000, Filipe Manana wrote:
[snip]
> Hi, thanks for this.
>
> However this doesn't make sense to me.
> This commit only touches btrfs' fsync handler and the test uses sysbench
> without passing --file-fsync-freq to it, which means sysbench will never
> do fsyncs according to its man page (default for fsync frequency is 0).
>
> Or maybe I missed something?
Sorry for late.
I checked source code of sysbench and found that the actual default
value of --file-fsync-freq is 100 instead of 0 in man page, as in the
following lines.
{"file-fsync-freq", "do fsync() after this number of requests (0 - don't use fsync())",
SB_ARG_TYPE_INT, "100"},
I double checked that via a debug patch to sysbench too.
Best Regards,
Huang, Ying
WARNING: multiple messages have this Message-ID (diff)
From: Huang Ying <ying.huang@intel.com>
To: Filipe Manana <fdmanana@suse.com>
Cc: Chris Mason <clm@fb.com>, LKML <linux-kernel@vger.kernel.org>,
LKP ML <lkp@01.org>
Subject: Re: [LKP] [Btrfs] 3a8b36f3780: -62.6% fileio.requests_per_sec
Date: Tue, 31 Mar 2015 16:32:47 +0800 [thread overview]
Message-ID: <1427790767.17170.95.camel@intel.com> (raw)
In-Reply-To: <55094E06.2070004@suse.com>
Hi, Filipe,
On Wed, 2015-03-18 at 10:05 +0000, Filipe Manana wrote:
[snip]
> Hi, thanks for this.
>
> However this doesn't make sense to me.
> This commit only touches btrfs' fsync handler and the test uses sysbench
> without passing --file-fsync-freq to it, which means sysbench will never
> do fsyncs according to its man page (default for fsync frequency is 0).
>
> Or maybe I missed something?
Sorry for late.
I checked source code of sysbench and found that the actual default
value of --file-fsync-freq is 100 instead of 0 in man page, as in the
following lines.
{"file-fsync-freq", "do fsync() after this number of requests (0 - don't use fsync())",
SB_ARG_TYPE_INT, "100"},
I double checked that via a debug patch to sysbench too.
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2015-03-31 8:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 8:20 [Btrfs] 3a8b36f3780: -62.6% fileio.requests_per_sec Huang Ying
2015-03-18 8:20 ` [LKP] " Huang Ying
2015-03-18 10:05 ` Filipe Manana
2015-03-18 10:05 ` [LKP] " Filipe Manana
2015-03-31 8:32 ` Huang Ying [this message]
2015-03-31 8:32 ` Huang Ying
2015-03-31 14:59 ` Filipe Manana
2015-03-31 14:59 ` [LKP] " Filipe Manana
2015-04-01 4:59 ` Huang Ying
2015-04-01 4:59 ` [LKP] " Huang Ying
2015-04-01 9:56 ` Filipe Manana
2015-04-01 9:56 ` [LKP] " Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427790767.17170.95.camel@intel.com \
--to=ying.huang@intel.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.