From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4 09/33] xen: Extend DOMCTL createdomain to
 support arch configuration
Date: Tue, 31 Mar 2015 11:39:31 +0100
Message-ID: <1427798371.2115.51.camel@citrix.com>
References: <1426793399-6283-1-git-send-email-julien.grall@linaro.org>
	<1426793399-6283-10-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Yctnb-0004OO-JD
	for xen-devel@lists.xenproject.org; Tue, 31 Mar 2015 10:53:35 +0000
In-Reply-To: <1426793399-6283-10-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xenproject.org, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-03-19 at 19:29 +0000, Julien Grall wrote:
> On ARM the virtual GIC may differ between each guest (emulated GIC version,
> number of SPIs...). This information is already known at the domain creation
> and can never change.
> 
> For now only the gic_version is set. In the long run, there will be more
> parameters such as the number of SPIs. All will be required to be set at the
> same time.
> 
> A new arch-specific structure arch_domainconfig has been created, the x86
> one doesn't have any specific configuration, for now, a dummy structure
> (C-spec compliant) has been created.
> 
> Some external tools (qemu, xenstore) may be required to create a domain.
> Rather than asking them to take care of the arch-specific domain
> configuration, let the current function (xc_domain_create) chose a
> default configuration and introduce a new one (xc_domain_create_config).
> 
> This patch also drops the previously introduced DOMCTL arm_configure_domain
> in Xen 4.5, as it has been made useless.
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

A couple of minor nits which I'll try and remember to fix on commit if a
resend of the series isn't needed for another reason.

> -    LOG(DEBUG, "  - vGIC version: %s", gicv_to_string(config.gic_version));
> +    LOG(DEBUG, " - vGIC version: %s\n", gicv_to_string(xc_config->gic_version));

Log adds the \n itself. 
>      /* Create initial domain 0. */
> -    dom0 = domain_create(0, 0, 0);
> +    /* The vGIC for DOM0 is exactly emulated the hardware GIC */

"emulating"

Ian.