All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Robbie VanVossen <robert.vanvossen@dornerworks.com>
Cc: julien.grall@citrix.com, xen-devel@lists.xenproject.org,
	edgar.iglesias@xilinx.com, Josh.Whitehead@dornerworks.com,
	Stefano.Stabellini@eu.citrix.com
Subject: Re: [PATCH v4] xen/passthrough: Support a single iommu_domain per xen domain per SMMU
Date: Tue, 31 Mar 2015 12:14:02 +0100	[thread overview]
Message-ID: <1427800442.2115.76.camel@citrix.com> (raw)
In-Reply-To: <1427230099-9115-1-git-send-email-robert.vanvossen@dornerworks.com>

On Tue, 2015-03-24 at 16:48 -0400, Robbie VanVossen wrote:
> If multiple devices are being passed through to the same domain and they
> share a single SMMU, then they only require a single iommu_domain.
> 
> In arm_smmu_assign_dev, before a new iommu_domain is created, the
> xen_domain->contexts is checked for any iommu_domains that are already
> assigned to device that uses the same SMMU as the current device. If one
> is found, attach the device to that iommu_domain. If a new one isn't
> found, create a new iommu_domain just like before.
> 
> The arm_smmu_deassign_dev function assumes that there is a single
> device per iommu_domain. This meant that when the first device was
> deassigned, the iommu_domain was freed and when another device was
> deassigned a crash occurred in xen.
> 
> To fix this, a reference counter was added to the iommu_domain struct.
> When an arm_smmu_xen_device references an iommu_domain, the
> iommu_domains ref is incremented. When that reference is removed, the
> iommu_domains ref is decremented. The iommu_domain will only be freed
> when the ref is 0.
> 
> Signed-off-by: Robbie VanVossen <robert.vanvossen@dornerworks.com>
> Reviewed-by: Julien Grall <julien.grall@linaro.org>

I was expecting this to come back in a new version of  Julien's
passthrough series, but Julien prodded me to say that this patch didn't
actually have any dependency/interaction with his passthrough series
like I thought, so it can go in now. 

So Acked + applied, sorry for the delay.

      reply	other threads:[~2015-03-31 11:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 20:48 [PATCH v4] xen/passthrough: Support a single iommu_domain per xen domain per SMMU Robbie VanVossen
2015-03-31 11:14 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427800442.2115.76.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Josh.Whitehead@dornerworks.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=julien.grall@citrix.com \
    --cc=robert.vanvossen@dornerworks.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.