From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 31/33] libxl: Add support for non-PCI passthrough Date: Tue, 31 Mar 2015 14:20:06 +0100 Message-ID: <1427808006.2115.127.camel@citrix.com> References: <1426793399-6283-1-git-send-email-julien.grall@linaro.org> <1426793399-6283-32-git-send-email-julien.grall@linaro.org> <1427802560.2115.102.camel@citrix.com> <551A9A62.9060509@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Ycw5U-0004dz-QD for xen-devel@lists.xenproject.org; Tue, 31 Mar 2015 13:20:12 +0000 In-Reply-To: <551A9A62.9060509@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, Ian Jackson , stefano.stabellini@citrix.com, Wei Liu List-Id: xen-devel@lists.xenproject.org On Tue, 2015-03-31 at 14:00 +0100, Julien Grall wrote: > >> +static void domcreate_attach_dtdev(libxl__egc *egc, > >> + libxl__domain_create_state *dcs) > > > > I know it isn't strictly needed, but I think for consistency this > > function should take a ret and check it + propagate it via > > domcreate_complete on error, like the other ones in the call chain do. > > The other caller have the ret because they use multidev. When it's not > the case (such as domcreate_console_available), the ret parameter is not > present. > > So I'm not keen to add a new unused parameter. OK, if it's inconsistent already no harm in another. > > Regards, >