Re: [PATCH v3 7/8] tools/libxl: introduce libxl_count_physical_sockets

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-03-31 at 16:51 +0800, Chao Peng wrote:
> > I think Ian suggested you make this an internal function not a public
> > API. But if I misunderstand Ian's intention, please make this function
> > return libxl error code. The socket number can be returned from an out
> > parameter. I.e.
> > 
> >    int libxl_count_physical_sockets(libxl_ctx *ctx, uint32_t *nr_sockets);
> > 
> Making it public is the need of supporting LIBXL_PSR_TARGET_ALL in
> libxl_psr_cat_set_cbm(), which is suggested by Ian as well. In such
> case, both xl/libxl need to get socket_count. Introduce it in libxl so
> that both can make use of it.

My expectation was that adding LIBXL_PSR_TARGET_ALL would remove the
need for xl to get the socket count, I expected that passing
LIBXL_PSR_TARGET_ALL would cause libxl to do all of that internally.
I've not looked at the next patch to see why that isn't the case though.

Ian.

> 
> Except this, I would like to adopt your suggestions(#ifdef to x86 only
> and return error code).
> 
> Chao