From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 5/5] xen: sched_rt: print useful affinity
 info when dumping
Date: Tue, 31 Mar 2015 16:58:23 +0000
Message-ID: <1427821102.10838.22.camel@citrix.com>
References: <20150317152615.9867.48676.stgit@Solace.station>
	<20150317153326.9867.76671.stgit@Solace.station>
	<55195407.3060608@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6764734532443545266=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55195407.3060608@eu.citrix.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@citrix.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, "xumengpanda@gmail.com" <xumengpanda@gmail.com>, "JBeulich@suse.com" <JBeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============6764734532443545266==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-6lC71YBnLwGjWoezNqoR"

--=-6lC71YBnLwGjWoezNqoR
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2015-03-30 at 14:47 +0100, George Dunlap wrote:
> On 03/17/2015 03:33 PM, Dario Faggioli wrote:

> > Such scratch area can be used to kill most of the
> > cpumasks{_var}_t local variables in other functions
> > in the file, but that is *NOT* done in this chage.
> >=20
> > Finally, convert the file to use keyhandler scratch,
> > instead of open coded string buffers.
> >=20
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > Cc: George Dunlap <george.dunlap@eu.citrix.com>
> > Cc: Meng Xu <xumengpanda@gmail.com>
> > Cc: Jan Beulich <JBeulich@suse.com>
> > Cc: Keir Fraser <keir@xen.org>
> > ---
> > Changes from v1:
> >  * improved changelog;
> >  * made a local variable to point to the correct
> >    scratch mask, as suggested during review.
>=20
> Thanks,
>=20
> Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>
>=20
Thanks to you, but I think this has an issue.

The same one that you spotted in Justin's Credit2 affinity series: the
scratch mask array should not be allocated in rt_init(), or at least not
without checking that it's not there already, or the creation of a new
cpupool with the same scheduler will screw things up.

So, at least this very patch needs a v3. It's pretty independent from
the rest of the series, which should be all acked by now, but I can
resend it all if it's easier/better, just let me know. :-)

Thanks again and Regards,
Dario

--=-6lC71YBnLwGjWoezNqoR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlUa0i4ACgkQk4XaBE3IOsTT2gCgiUg8pXdZdcTHDz2w6Rouzyjf
z/YAn1+yxKmgREZX0xKtGinQSeji5q6k
=J1Tp
-----END PGP SIGNATURE-----

--=-6lC71YBnLwGjWoezNqoR--


--===============6764734532443545266==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6764734532443545266==--