From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754174AbbCaVKp (ORCPT ); Tue, 31 Mar 2015 17:10:45 -0400 Received: from mga11.intel.com ([192.55.52.93]:23221 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbbCaVKi (ORCPT ); Tue, 31 Mar 2015 17:10:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,503,1422950400"; d="scan'208";a="475099608" From: "Keller, Jacob E" To: "richardcochran@gmail.com" CC: "linux-kernel@vger.kernel.org" , "baolin.wang@linaro.org" , "b45643@freescale.com" , "amirv@mellanox.com" , "peppe.cavallaro@st.com" , "sonic.zhang@analog.com" , "rayagond@vayavyalabs.com" , "tglx@linutronix.de" , "sony.chacko@qlogic.com" , "Vick, Matthew" , "arnd@linaro.org" , "Frank.Li@freescale.com" , "netdev@vger.kernel.org" , "mchan@broadcom.com" , "prashant@broadcom.com" , "davem@davemloft.net" , "Kirsher, Jeffrey T" , "john.stultz@linaro.org" Subject: Re: [PATCH net-next 06/11] ptp: e1000e: use helpers for converting ns to timespec. Thread-Topic: [PATCH net-next 06/11] ptp: e1000e: use helpers for converting ns to timespec. Thread-Index: AQHQa/bemS7N9RAgQ0az+KNZmR9MGZ03i64A Date: Tue, 31 Mar 2015 21:10:36 +0000 Message-ID: <1427836236.16312.28.camel@intel.com> References: <051364a3a57d36200f652f4d8e1c9bfc4edf3254.1427835485.git.richardcochran@gmail.com> In-Reply-To: <051364a3a57d36200f652f4d8e1c9bfc4edf3254.1427835485.git.richardcochran@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [134.134.3.151] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t2VLAtU1030703 On Tue, 2015-03-31 at 23:08 +0200, Richard Cochran wrote: > This patch changes the driver to use ns_to_timespec64() instead of > open coding the same logic. > > Compile tested only. > > Signed-off-by: Richard Cochran > --- > drivers/net/ethernet/intel/e1000e/ptp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/e1000e/ptp.c b/drivers/net/ethernet/intel/e1000e/ptp.c > index b747a3e..d2272ad 100644 > --- a/drivers/net/ethernet/intel/e1000e/ptp.c > +++ b/drivers/net/ethernet/intel/e1000e/ptp.c > @@ -111,15 +111,13 @@ static int e1000e_phc_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts) > struct e1000_adapter *adapter = container_of(ptp, struct e1000_adapter, > ptp_clock_info); > unsigned long flags; > - u32 remainder; > u64 ns; > > spin_lock_irqsave(&adapter->systim_lock, flags); > ns = timecounter_read(&adapter->tc); > spin_unlock_irqrestore(&adapter->systim_lock, flags); > > - ts->tv_sec = div_u64_rem(ns, NSEC_PER_SEC, &remainder); > - ts->tv_nsec = remainder; > + *ts = ns_to_timespec64(ns); > > return 0; > } Acked-by: Jacob Keller {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keller, Jacob E" Subject: Re: [PATCH net-next 06/11] ptp: e1000e: use helpers for converting ns to timespec. Date: Tue, 31 Mar 2015 21:10:36 +0000 Message-ID: <1427836236.16312.28.camel@intel.com> References: <051364a3a57d36200f652f4d8e1c9bfc4edf3254.1427835485.git.richardcochran@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "linux-kernel@vger.kernel.org" , "baolin.wang@linaro.org" , "b45643@freescale.com" , "amirv@mellanox.com" , "peppe.cavallaro@st.com" , "sonic.zhang@analog.com" , "rayagond@vayavyalabs.com" , "tglx@linutronix.de" , "sony.chacko@qlogic.com" , "Vick, Matthew" , "arnd@linaro.org" , "Frank.Li@freescale.com" , "netdev@vger.kernel.org" , "mchan@broadcom.com" , "prashant@broadcom.com" , "davem@davemloft.net" , "Kirsher, Jeffrey T" , "john.stultz@linaro.org" To: "richardcochran@gmail.com" Return-path: In-Reply-To: <051364a3a57d36200f652f4d8e1c9bfc4edf3254.1427835485.git.richardcochran@gmail.com> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org T24gVHVlLCAyMDE1LTAzLTMxIGF0IDIzOjA4ICswMjAwLCBSaWNoYXJkIENvY2hyYW4gd3JvdGU6 DQo+IFRoaXMgcGF0Y2ggY2hhbmdlcyB0aGUgZHJpdmVyIHRvIHVzZSBuc190b190aW1lc3BlYzY0 KCkgaW5zdGVhZCBvZg0KPiBvcGVuIGNvZGluZyB0aGUgc2FtZSBsb2dpYy4NCj4gDQo+IENvbXBp bGUgdGVzdGVkIG9ubHkuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBSaWNoYXJkIENvY2hyYW4gPHJp Y2hhcmRjb2NocmFuQGdtYWlsLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9p bnRlbC9lMTAwMGUvcHRwLmMgfCAgICA0ICstLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKSwgMyBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9l dGhlcm5ldC9pbnRlbC9lMTAwMGUvcHRwLmMgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9pbnRlbC9l MTAwMGUvcHRwLmMNCj4gaW5kZXggYjc0N2EzZS4uZDIyNzJhZCAxMDA2NDQNCj4gLS0tIGEvZHJp dmVycy9uZXQvZXRoZXJuZXQvaW50ZWwvZTEwMDBlL3B0cC5jDQo+ICsrKyBiL2RyaXZlcnMvbmV0 L2V0aGVybmV0L2ludGVsL2UxMDAwZS9wdHAuYw0KPiBAQCAtMTExLDE1ICsxMTEsMTMgQEAgc3Rh dGljIGludCBlMTAwMGVfcGhjX2dldHRpbWUoc3RydWN0IHB0cF9jbG9ja19pbmZvICpwdHAsIHN0 cnVjdCB0aW1lc3BlYzY0ICp0cykNCj4gIAlzdHJ1Y3QgZTEwMDBfYWRhcHRlciAqYWRhcHRlciA9 IGNvbnRhaW5lcl9vZihwdHAsIHN0cnVjdCBlMTAwMF9hZGFwdGVyLA0KPiAgCQkJCQkJICAgICBw dHBfY2xvY2tfaW5mbyk7DQo+ICAJdW5zaWduZWQgbG9uZyBmbGFnczsNCj4gLQl1MzIgcmVtYWlu ZGVyOw0KPiAgCXU2NCBuczsNCj4gIA0KPiAgCXNwaW5fbG9ja19pcnFzYXZlKCZhZGFwdGVyLT5z eXN0aW1fbG9jaywgZmxhZ3MpOw0KPiAgCW5zID0gdGltZWNvdW50ZXJfcmVhZCgmYWRhcHRlci0+ dGMpOw0KPiAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmFkYXB0ZXItPnN5c3RpbV9sb2NrLCBm bGFncyk7DQo+ICANCj4gLQl0cy0+dHZfc2VjID0gZGl2X3U2NF9yZW0obnMsIE5TRUNfUEVSX1NF QywgJnJlbWFpbmRlcik7DQo+IC0JdHMtPnR2X25zZWMgPSByZW1haW5kZXI7DQo+ICsJKnRzID0g bnNfdG9fdGltZXNwZWM2NChucyk7DQo+ICANCj4gIAlyZXR1cm4gMDsNCj4gIH0NCg0KDQpBY2tl ZC1ieTogSmFjb2IgS2VsbGVyIDxqYWNvYi5lLmtlbGxlckBpbnRlbC5jb20+DQo=