From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754317AbbCaVME (ORCPT ); Tue, 31 Mar 2015 17:12:04 -0400 Received: from mga09.intel.com ([134.134.136.24]:43952 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754215AbbCaVLl (ORCPT ); Tue, 31 Mar 2015 17:11:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,503,1422950400"; d="scan'208";a="688506639" From: "Keller, Jacob E" To: "richardcochran@gmail.com" CC: "linux-kernel@vger.kernel.org" , "baolin.wang@linaro.org" , "b45643@freescale.com" , "amirv@mellanox.com" , "peppe.cavallaro@st.com" , "sonic.zhang@analog.com" , "rayagond@vayavyalabs.com" , "tglx@linutronix.de" , "sony.chacko@qlogic.com" , "Vick, Matthew" , "arnd@linaro.org" , "Frank.Li@freescale.com" , "netdev@vger.kernel.org" , "mchan@broadcom.com" , "prashant@broadcom.com" , "davem@davemloft.net" , "Kirsher, Jeffrey T" , "john.stultz@linaro.org" Subject: Re: [PATCH net-next 00/11] remove open coded ns_to_timespec64 and reverse Thread-Topic: [PATCH net-next 00/11] remove open coded ns_to_timespec64 and reverse Thread-Index: AQHQa/bUR8fiI5z5A0+3XJLV0FGnhp03i+4A Date: Tue, 31 Mar 2015 21:11:30 +0000 Message-ID: <1427836290.16312.29.camel@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [134.134.3.151] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t2VLC9N2030735 On Tue, 2015-03-31 at 23:08 +0200, Richard Cochran wrote: > This patch series is a follow up to the recent timespec64 work for the > PTP Hardware Clock drivers. Arnd noticed that drivers are using open > coded implementations of ns_to_timespec64 and timespec64_to_ns. This > series replaces the open coded logic with the helper functions. > > Thanks, > Richard > > Richard Cochran (11): > ptp: blackfin: use helpers for converting ns to timespec. > ptp: bnx2x: use helpers for converting ns to timespec. > ptp: tg3: use helpers for converting ns to timespec. > ptp: fec: use helpers for converting ns to timespec. > ptp: gianfar: use helpers for converting ns to timespec. > ptp: e1000e: use helpers for converting ns to timespec. > ptp: igb: use helpers for converting ns to timespec. > ptp: ixgbe: use helpers for converting ns to timespec. > ptp: mlx4: use helpers for converting ns to timespec. > ptp: stmmac: use helpers for converting ns to timespec. > ptp: cpts: use helpers for converting ns to timespec. > > drivers/net/ethernet/adi/bfin_mac.c | 8 +++----- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 7 ++----- > drivers/net/ethernet/broadcom/tg3.c | 4 +--- > drivers/net/ethernet/freescale/fec_ptp.c | 7 ++----- > drivers/net/ethernet/freescale/gianfar_ptp.c | 8 +++----- > drivers/net/ethernet/intel/e1000e/ptp.c | 4 +--- > drivers/net/ethernet/intel/igb/igb_ptp.c | 7 ++----- > drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 7 ++----- > drivers/net/ethernet/mellanox/mlx4/en_clock.c | 4 +--- > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 4 +--- > drivers/net/ethernet/ti/cpts.c | 7 ++----- > 11 files changed, 20 insertions(+), 47 deletions(-) > For all the Intel drivers, this looks fine. I'm surprised I never noticed before. Acked-by: Jacob Keller {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keller, Jacob E" Subject: Re: [PATCH net-next 00/11] remove open coded ns_to_timespec64 and reverse Date: Tue, 31 Mar 2015 21:11:30 +0000 Message-ID: <1427836290.16312.29.camel@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "linux-kernel@vger.kernel.org" , "baolin.wang@linaro.org" , "b45643@freescale.com" , "amirv@mellanox.com" , "peppe.cavallaro@st.com" , "sonic.zhang@analog.com" , "rayagond@vayavyalabs.com" , "tglx@linutronix.de" , "sony.chacko@qlogic.com" , "Vick, Matthew" , "arnd@linaro.org" , "Frank.Li@freescale.com" , "netdev@vger.kernel.org" , "mchan@broadcom.com" , "prashant@broadcom.com" , "davem@davemloft.net" , "Kirsher, Jeffrey T" , "john.stultz@linaro.org" To: "richardcochran@gmail.com" Return-path: Received: from mga09.intel.com ([134.134.136.24]:43952 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754215AbbCaVLl (ORCPT ); Tue, 31 Mar 2015 17:11:41 -0400 In-Reply-To: Content-Language: en-US Content-ID: Sender: netdev-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDE1LTAzLTMxIGF0IDIzOjA4ICswMjAwLCBSaWNoYXJkIENvY2hyYW4gd3JvdGU6 DQo+IFRoaXMgcGF0Y2ggc2VyaWVzIGlzIGEgZm9sbG93IHVwIHRvIHRoZSByZWNlbnQgdGltZXNw ZWM2NCB3b3JrIGZvciB0aGUNCj4gUFRQIEhhcmR3YXJlIENsb2NrIGRyaXZlcnMuICBBcm5kIG5v dGljZWQgdGhhdCBkcml2ZXJzIGFyZSB1c2luZyBvcGVuDQo+IGNvZGVkIGltcGxlbWVudGF0aW9u cyBvZiBuc190b190aW1lc3BlYzY0IGFuZCB0aW1lc3BlYzY0X3RvX25zLiAgVGhpcw0KPiBzZXJp ZXMgcmVwbGFjZXMgdGhlIG9wZW4gY29kZWQgbG9naWMgd2l0aCB0aGUgaGVscGVyIGZ1bmN0aW9u cy4NCj4gDQo+IFRoYW5rcywNCj4gUmljaGFyZA0KPiANCj4gUmljaGFyZCBDb2NocmFuICgxMSk6 DQo+ICAgcHRwOiBibGFja2ZpbjogdXNlIGhlbHBlcnMgZm9yIGNvbnZlcnRpbmcgbnMgdG8gdGlt ZXNwZWMuDQo+ICAgcHRwOiBibngyeDogdXNlIGhlbHBlcnMgZm9yIGNvbnZlcnRpbmcgbnMgdG8g dGltZXNwZWMuDQo+ICAgcHRwOiB0ZzM6IHVzZSBoZWxwZXJzIGZvciBjb252ZXJ0aW5nIG5zIHRv IHRpbWVzcGVjLg0KPiAgIHB0cDogZmVjOiB1c2UgaGVscGVycyBmb3IgY29udmVydGluZyBucyB0 byB0aW1lc3BlYy4NCj4gICBwdHA6IGdpYW5mYXI6IHVzZSBoZWxwZXJzIGZvciBjb252ZXJ0aW5n IG5zIHRvIHRpbWVzcGVjLg0KPiAgIHB0cDogZTEwMDBlOiB1c2UgaGVscGVycyBmb3IgY29udmVy dGluZyBucyB0byB0aW1lc3BlYy4NCj4gICBwdHA6IGlnYjogdXNlIGhlbHBlcnMgZm9yIGNvbnZl cnRpbmcgbnMgdG8gdGltZXNwZWMuDQo+ICAgcHRwOiBpeGdiZTogdXNlIGhlbHBlcnMgZm9yIGNv bnZlcnRpbmcgbnMgdG8gdGltZXNwZWMuDQo+ICAgcHRwOiBtbHg0OiB1c2UgaGVscGVycyBmb3Ig Y29udmVydGluZyBucyB0byB0aW1lc3BlYy4NCj4gICBwdHA6IHN0bW1hYzogdXNlIGhlbHBlcnMg Zm9yIGNvbnZlcnRpbmcgbnMgdG8gdGltZXNwZWMuDQo+ICAgcHRwOiBjcHRzOiB1c2UgaGVscGVy cyBmb3IgY29udmVydGluZyBucyB0byB0aW1lc3BlYy4NCj4gDQo+ICBkcml2ZXJzL25ldC9ldGhl cm5ldC9hZGkvYmZpbl9tYWMuYyAgICAgICAgICAgICAgfCAgICA4ICsrKy0tLS0tDQo+ICBkcml2 ZXJzL25ldC9ldGhlcm5ldC9icm9hZGNvbS9ibngyeC9ibngyeF9tYWluLmMgfCAgICA3ICsrLS0t LS0NCj4gIGRyaXZlcnMvbmV0L2V0aGVybmV0L2Jyb2FkY29tL3RnMy5jICAgICAgICAgICAgICB8 ICAgIDQgKy0tLQ0KPiAgZHJpdmVycy9uZXQvZXRoZXJuZXQvZnJlZXNjYWxlL2ZlY19wdHAuYyAg ICAgICAgIHwgICAgNyArKy0tLS0tDQo+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9mcmVlc2NhbGUv Z2lhbmZhcl9wdHAuYyAgICAgfCAgICA4ICsrKy0tLS0tDQo+ICBkcml2ZXJzL25ldC9ldGhlcm5l dC9pbnRlbC9lMTAwMGUvcHRwLmMgICAgICAgICAgfCAgICA0ICstLS0NCj4gIGRyaXZlcnMvbmV0 L2V0aGVybmV0L2ludGVsL2lnYi9pZ2JfcHRwLmMgICAgICAgICB8ICAgIDcgKystLS0tLQ0KPiAg ZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwvaXhnYmUvaXhnYmVfcHRwLmMgICAgIHwgICAgNyAr Ky0tLS0tDQo+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg0L2VuX2Nsb2NrLmMg ICAgfCAgICA0ICstLS0NCj4gIGRyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL3N0 bW1hY19wdHAuYyB8ICAgIDQgKy0tLQ0KPiAgZHJpdmVycy9uZXQvZXRoZXJuZXQvdGkvY3B0cy5j ICAgICAgICAgICAgICAgICAgIHwgICAgNyArKy0tLS0tDQo+ICAxMSBmaWxlcyBjaGFuZ2VkLCAy MCBpbnNlcnRpb25zKCspLCA0NyBkZWxldGlvbnMoLSkNCj4gDQoNCkZvciBhbGwgdGhlIEludGVs IGRyaXZlcnMsIHRoaXMgbG9va3MgZmluZS4gSSdtIHN1cnByaXNlZCBJIG5ldmVyDQpub3RpY2Vk IGJlZm9yZS4NCg0KQWNrZWQtYnk6IEphY29iIEtlbGxlciA8amFjb2IuZS5rZWxsZXJAaW50ZWwu Y29tPg0K