From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0093.hostedemail.com. [216.40.44.93]) by gmr-mx.google.com with ESMTP id bz6si952137wib.3.2015.04.01.00.15.15 for ; Wed, 01 Apr 2015 00:15:16 -0700 (PDT) Message-ID: <1427872512.31790.3.camel@perches.com> Subject: Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log From: Joe Perches To: Alessandro Zummo Cc: Alexandre Belloni , Aaro Koskinen , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Date: Wed, 01 Apr 2015 00:15:12 -0700 In-Reply-To: <20150401090520.559ead39@linux.lan.towertech.it> References: <1427576976-22353-1-git-send-email-aaro.koskinen@iki.fi> <1427576976-22353-3-git-send-email-aaro.koskinen@iki.fi> <20150401030124.GO3849@piout.net> <1427858308.18175.30.camel@perches.com> <20150401090520.559ead39@linux.lan.towertech.it> Content-Type: text/plain; charset=UTF-8 Mime-Version: 1.0 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Wed, 2015-04-01 at 09:05 +0200, Alessandro Zummo wrote: > On Tue, 31 Mar 2015 20:18:28 -0700 > Joe Perches wrote: > > > Neither __func__ or __FILE__ is really useful here. > > The message is already specific enough without it. > > > > If anything, it'd probably be better to add > > > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Seems reasonable given that pr_fmt is widely > used elsewhere. > > I don't like too much the need to have one define for > each file, but it's the way it works :-/ True. Right now. I've a desire to make a change one day so that's the default instead of blank. http://comments.gmane.org/gmane.linux.kernel/1052288 There are some remaining treewide complications before that can be done effectively though. A few files will need "#define pr_fmt(fmt) fmt" so no prefix is used. -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989AbbDAHPV (ORCPT ); Wed, 1 Apr 2015 03:15:21 -0400 Received: from smtprelay0016.hostedemail.com ([216.40.44.16]:53383 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752439AbbDAHPQ (ORCPT ); Wed, 1 Apr 2015 03:15:16 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:6261:8599:8985:9025:10004:10400:10848:10967:11232:11658:11914:12043:12050:12296:12517:12519:12555:12682:12740:13018:13019:13069:13095:13161:13229:13255:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: offer15_4ac69abc3f22f X-Filterd-Recvd-Size: 2007 Message-ID: <1427872512.31790.3.camel@perches.com> Subject: Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log From: Joe Perches To: Alessandro Zummo Cc: Alexandre Belloni , Aaro Koskinen , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Date: Wed, 01 Apr 2015 00:15:12 -0700 In-Reply-To: <20150401090520.559ead39@linux.lan.towertech.it> References: <1427576976-22353-1-git-send-email-aaro.koskinen@iki.fi> <1427576976-22353-3-git-send-email-aaro.koskinen@iki.fi> <20150401030124.GO3849@piout.net> <1427858308.18175.30.camel@perches.com> <20150401090520.559ead39@linux.lan.towertech.it> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-04-01 at 09:05 +0200, Alessandro Zummo wrote: > On Tue, 31 Mar 2015 20:18:28 -0700 > Joe Perches wrote: > > > Neither __func__ or __FILE__ is really useful here. > > The message is already specific enough without it. > > > > If anything, it'd probably be better to add > > > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Seems reasonable given that pr_fmt is widely > used elsewhere. > > I don't like too much the need to have one define for > each file, but it's the way it works :-/ True. Right now. I've a desire to make a change one day so that's the default instead of blank. http://comments.gmane.org/gmane.linux.kernel/1052288 There are some remaining treewide complications before that can be done effectively though. A few files will need "#define pr_fmt(fmt) fmt" so no prefix is used.