From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST Nested PATCH v7 2/6] Edit some testsupport
 APIs for nested test
Date: Wed, 1 Apr 2015 09:50:54 +0100
Message-ID: <1427878254.2115.225.camel@citrix.com>
References: <1427497587-22884-1-git-send-email-longtaox.pang@intel.com>
	<1427497587-22884-3-git-send-email-longtaox.pang@intel.com>
	<1427809798.2115.135.camel@citrix.com>
	<86C3224E41A7434B904EC364302132D80E487BFD@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <86C3224E41A7434B904EC364302132D80E487BFD@SHSMSX101.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Pang, LongtaoX" <longtaox.pang@intel.com>
Cc: "wei.liu2@citrix.com" <wei.liu2@citrix.com>, "Hu,
	Robert" <robert.hu@intel.com>, "Ian.Jackson@eu.citrix.com" <Ian.Jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-04-01 at 05:56 +0000, Pang, LongtaoX wrote:
> 
> 
> > -----Original Message-----
> > From: Ian Campbell [mailto:ian.campbell@citrix.com]
> > Sent: Tuesday, March 31, 2015 9:50 PM
> > To: Pang, LongtaoX
> > Cc: xen-devel@lists.xen.org; Ian.Jackson@eu.citrix.com; wei.liu2@citrix.com;
> > Hu, Robert
> > Subject: Re: [OSSTEST Nested PATCH v7 2/6] Edit some testsupport APIs for
> > nested test
> > 
> > On Fri, 2015-03-27 at 19:06 -0400, longtao.pang wrote:
> > > 1. Designate vif model to 'e1000' by make-flight.
> > 
> > Strictly you could s/to 'e1000'// here since the make-flight changes are
> > elsewhere and that would better describe the generic change.
> > 
> Do you mean that I should change the description from "Designate vif
> model to 'e1000' by make-flight" to "Designate vif model by
> make-flight"?

Yes, or even better "Add runvar to allow override of default VIF model".

> > > 2. In L2 installation context, its host (L1) IP address is not queried
> > > from DNS, but after running "ts-nested-setup + host + nested", L1 IP
> > > is stored in runvar.
> > >
> > > Signed-off-by: longtao.pang <longtaox.pang@intel.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
>