From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST Nested PATCH v7 3/6] Changes on test step of debain hvm guest install Date: Wed, 1 Apr 2015 09:53:45 +0100 Message-ID: <1427878425.2115.228.camel@citrix.com> References: <1427497587-22884-1-git-send-email-longtaox.pang@intel.com> <1427497587-22884-4-git-send-email-longtaox.pang@intel.com> <1427810141.2115.140.camel@citrix.com> <86C3224E41A7434B904EC364302132D80E487D9F@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <86C3224E41A7434B904EC364302132D80E487D9F@SHSMSX101.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Pang, LongtaoX" Cc: "wei.liu2@citrix.com" , "Hu, Robert" , "Ian.Jackson@eu.citrix.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, 2015-04-01 at 08:19 +0000, Pang, LongtaoX wrote: > > > > -----Original Message----- > > From: Ian Campbell [mailto:ian.campbell@citrix.com] > > Sent: Tuesday, March 31, 2015 9:56 PM > > To: Pang, LongtaoX > > Cc: xen-devel@lists.xen.org; Ian.Jackson@eu.citrix.com; wei.liu2@citrix.com; > > Hu, Robert > > Subject: Re: [OSSTEST Nested PATCH v7 3/6] Changes on test step of debain > > hvm guest install > > > > On Fri, 2015-03-27 at 19:06 -0400, longtao.pang wrote: > > > 1. Increase disk size to accomodate to nested test requirment. > > > > "accommodate" and "requirement" > > > > Ian, are you OK with this generic change or would you prefer a runvar? I > > suspect the answer is going to be runvar. > > > So, should I waiting for Ian Jackson's reply and then take next action? Yes, or you could just make it a runvar because I'm sure Ian wouldn't object to that. > > > 2. Since 'Debain-xxx-.iso' image will be stored there, therefore needs > > > more disk capacity, increase root partition size in preseed generation. > > > > "Debian". > > > > I'm not sure I follow what this one is saying though, does "there" refer to the > > rootfs of the VM which is being built here? > Yes. "...image will be stored in the rootfs of the L1 guest, therefore needs..." Would be cleaner. > > > + ExtraConfig => 'nestedhvm=1', > > > > Please do only for the nested job i.e. using a runvar. > I remembered in previous mail you mentioned as below: > "One good thing about just enabling it from the start is that we get > some testing of normal guest installation while nestedhvm happens to > be installed, which might help catch regressions." > Therefore, I enabled 'nestedhvm' feature as generally. Sorry, I was ambiguous there, I meant from the start of the nestedhvm related jobs only, not for every job. I should have said "some testing of normal guest installation while we install the L1 hypervisor VM" or something along those lines. Ian.