From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [RFC PATCH v2 09/22] xen/arm: its: Add helper functions to decode ITS Command Date: Wed, 1 Apr 2015 12:40:30 +0100 Message-ID: <1427888430.2115.275.camel@citrix.com> References: <1426775889-29442-1-git-send-email-vijay.kilari@gmail.com> <1426775889-29442-10-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426775889-29442-10-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com Cc: stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-03-19 at 20:07 +0530, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > Add helper functions to decode ITS command > This will be useful for Virtual ITS driver It depends slightly on the answer to the quesiton I asked on patch #6, but in general in Xen we have preferred to define a structure/union overlaying the processor's view of such things and to use access to those fields, see e.g. the hsr decode or the pte stuff. Ian.