From: Cristina Opriceana <cristina.opriceana@gmail.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
outreachy-kernel@googlegroups.com,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 2/2] iio: light: ltr501: Powerdown device on error
Date: Wed, 01 Apr 2015 14:57:44 +0300 [thread overview]
Message-ID: <1427889464.6503.2.camel@Inspiron> (raw)
In-Reply-To: <CAEnQRZAVb_70+Fyj+PiXLQ3ShZTomafE3ZEnCFUEkhQnb8ERYg@mail.gmail.com>
On Mi, 2015-04-01 at 14:46 +0300, Daniel Baluta wrote:
> On Wed, Apr 1, 2015 at 2:01 PM, Cristina Opriceana
> <cristina.opriceana@gmail.com> wrote:
> > Power down device when an error occurs in order to avoid wasting
> > power. Also move powerdown function up to be seen by the new call.
> >
> > Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
> > ---
> > drivers/iio/light/ltr501.c | 18 ++++++++++--------
> > 1 file changed, 10 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
> > index 62b7072..29ca4b8 100644
> > --- a/drivers/iio/light/ltr501.c
> > +++ b/drivers/iio/light/ltr501.c
> > @@ -333,6 +333,13 @@ static int ltr501_init(struct ltr501_data *data)
> > data->ps_contr);
> > }
> >
> > +static int ltr501_powerdown(struct ltr501_data *data)
> > +{
> > + return ltr501_write_contr(data->client,
> > + data->als_contr & ~LTR501_CONTR_ACTIVE,
> > + data->ps_contr & ~LTR501_CONTR_ACTIVE);
> > +}
> > +
> Don't forget
> to mention this in the commit message. When running checkpatch.pl
> please use --strict parameter.
Okay, I'll make a v2. Ignore my previous question.
Thanks,
Cristina
> thanks,
> Daniel.
next prev parent reply other threads:[~2015-04-01 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 11:00 [PATCH 0/2] iio: Place drivers on standby on error Cristina Opriceana
2015-04-01 11:01 ` [PATCH 1/2] iio: magnetometer: mag3110: Place driver " Cristina Opriceana
2015-04-01 11:01 ` [PATCH 2/2] iio: light: ltr501: Powerdown device " Cristina Opriceana
2015-04-01 11:46 ` Daniel Baluta
2015-04-01 11:50 ` Cristina Opriceana
2015-04-01 11:57 ` Cristina Opriceana [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-29 12:19 [PATCH 0/2] iio: Place drivers on standby " Cristina Opriceana
2015-03-29 12:24 ` [PATCH 2/2] iio: light: ltr501: Powerdown device " Cristina Opriceana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427889464.6503.2.camel@Inspiron \
--to=cristina.opriceana@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.