From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH drm] drm/vgem: vgem_gem_dumb_map() can be static Date: Wed, 01 Apr 2015 20:04:55 -0700 Message-ID: <1427943895.18444.4.camel@perches.com> References: <201504021036.7YJmcdVc%fengguang.wu@intel.com> <20150402025959.GA15100@snb> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtprelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by gabe.freedesktop.org (Postfix) with ESMTP id BEE656E01C for ; Wed, 1 Apr 2015 20:05:00 -0700 (PDT) In-Reply-To: <20150402025959.GA15100@snb> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: kbuild test robot Cc: Ben Widawsky , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Zach Reizner , kbuild-all@01.org, Dave Airlie List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMDE1LTA0LTAyIGF0IDEwOjU5ICswODAwLCBrYnVpbGQgdGVzdCByb2JvdCB3cm90 ZToKPiBTaWduZWQtb2ZmLWJ5OiBGZW5nZ3VhbmcgV3UgPGZlbmdndWFuZy53dUBpbnRlbC5jb20+ CltdCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92Z2VtL3ZnZW1fZHJ2LmMgYi9kcml2 ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Rydi5jCltdCj4gQEAgLTE5NSw3ICsxOTUsNyBAQCBzdGF0 aWMgaW50IHZnZW1fZ2VtX2R1bWJfY3JlYXRlKHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwgc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC1pbnQgdmdlbV9nZW1f ZHVtYl9tYXAoc3RydWN0IGRybV9maWxlICpmaWxlLCBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ICtzdGF0aWMgaW50IHZnZW1fZ2VtX2R1bWJfbWFwKHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwgc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkgICAgICB1aW50MzJfdCBoYW5kbGUsIHVpbnQ2NF90 ICpvZmZzZXQpCgpIZWxsbyBGZW5nZ3VhbmcuCgpXaGVuIHlvdSBvciB5b3VyIHJvYm90IGRvZXMg dGhlc2UsIGNhbiB5b3UgcGxlYXNlCm1ha2Ugc3VyZSB0aGUgZW50aXJlIHN0YXRlbWVudCBpcyBp bmRlbnRlZCBwcm9wZXJseT8KCnRoYW5rcywKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673AbbDBDFC (ORCPT ); Wed, 1 Apr 2015 23:05:02 -0400 Received: from smtprelay0252.hostedemail.com ([216.40.44.252]:52897 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752093AbbDBDFA (ORCPT ); Wed, 1 Apr 2015 23:05:00 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3871:3873:4321:4362:4605:5007:6261:10004:10400:10848:11026:11232:11657:11658:11914:12043:12296:12438:12517:12519:12740:13069:13071:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: rings55_82af42783a836 X-Filterd-Recvd-Size: 1726 Message-ID: <1427943895.18444.4.camel@perches.com> Subject: Re: [PATCH drm] drm/vgem: vgem_gem_dumb_map() can be static From: Joe Perches To: kbuild test robot Cc: Zach Reizner , kbuild-all@01.org, Dave Airlie , Adam Jackson , Ben Widawsky , David Airlie , Rob Clark , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 01 Apr 2015 20:04:55 -0700 In-Reply-To: <20150402025959.GA15100@snb> References: <201504021036.7YJmcdVc%fengguang.wu@intel.com> <20150402025959.GA15100@snb> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-04-02 at 10:59 +0800, kbuild test robot wrote: > Signed-off-by: Fengguang Wu [] > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c [] > @@ -195,7 +195,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev, > return 0; > } > > -int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, > +static int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, > uint32_t handle, uint64_t *offset) Hello Fengguang. When you or your robot does these, can you please make sure the entire statement is indented properly? thanks,