All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [OSSTEST] ms-planner: add a flight summary html report
Date: Thu, 2 Apr 2015 12:03:35 +0100	[thread overview]
Message-ID: <1427972615.4037.48.camel@citrix.com> (raw)
In-Reply-To: <21345.6748.9086.717380@mariner.uk.xensource.com>

Resurrecting this old thing...

On Wed, 2014-04-30 at 16:44 +0100, Ian Jackson wrote:
> I think this is a nice thing to have, but:
> 
> > +    while (my ($reso,$evts) = each %{ $plan->{Events} }) {
> > +        # [osstest real] job 26010.test-amd64-amd64-xl-win7-amd64
> > +        foreach my $evt ( @{$evts} ) {
> > +            next unless $evt->{Type} =~ m/^(Start|End)$/;
> > +            next unless $evt->{Info} =~ m/^\[(\S+) (\S+)\] job ([0-9]+)\
> \.(\S+) (.*)/;
> 
> This is rather a layering violation.  Info is for the consumption of
> humans.  Perhaps the plan should have an explicit "flight.job" field.

I think in principal that's as simple as the two patches below which add
it to the booking in ts-hosts-allocate-Executive and propagate it to the
plan in ms-planner, but I'm not really sure and I don't know how to test
the queuedaemon/planner stuff.

However is even "$flight.$job" not a layering violation? Or were you
thinking that perhaps generically it would be
"<thing>.<sub-thing>.<sub-sub-thing>"? Still, the code to generate the
summary would need to know about the concept of flights etc and hence
probably doesn't belong in ms-planner.

> You could compute the "[linux-3.4 real]" part by looking at the common
> prefix of all the Infos.

Unfortunately the common prefix of the Info is generally at least
"[linux-3.4 real] job" and depending on the set of jobs currently
running it might even be "[linux-3.4 real] job build-", "[linux-3.4
real] job test-" or even "[linux-3.4 real] job test-amd64-amd64".

With all that in mind I've been thinking of coming at this from the
other end and starting with the set of flights which are not finished
and enumerating their jobs as pass/fail/inprogress/planned with the
appropriate times listed.

Only problem is I can't seem to identify in the DB which flights are not
completed, neither the flights table nor the jobs one seems to
consistently reflect that status. Is this possible to find out without
"ps"?

Ian.

      parent reply	other threads:[~2015-04-02 11:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28  9:24 [OSSTEST] ms-planner: add a flight summary html report Ian Campbell
2014-04-30 15:44 ` Ian Jackson
2014-04-30 15:58   ` Ian Campbell
2014-04-30 16:21     ` Ian Jackson
2014-04-30 16:29       ` Ian Campbell
2014-05-01 11:09         ` Ian Jackson
2015-04-02 11:03   ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427972615.4037.48.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.