From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v4 05/25] Debian: refactor preseeding of .ssh directories Date: Thu, 2 Apr 2015 13:39:17 +0100 Message-ID: <1427978357.4037.69.camel@citrix.com> References: <1427966183.4037.17.camel@citrix.com> <1427966199-5064-5-git-send-email-ian.campbell@citrix.com> <21789.10496.425187.458425@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21789.10496.425187.458425@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: longtaox.pang@intel.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-04-02 at 12:33 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST v4 05/25] Debian: refactor preseeding of .ssh directories"): > > Causes known_hosts to be consistently created as well as ~osstest/.ssh > > to be consistently populated (it previsouly wasn't for HVM guests). > > Most of this is code motion, AFAICT. The difference is just that > preseed_ssh is now called from ts-debian-hvm-install, too ? > > Why should preseed_ssh not be used by preseed_base ? Good question, I think it could be. At least I can't think of any sort of preseedable thing we would want to install which doesn't want this. I'll try it for next time. preseed_base today is only concerned with creating the base text for the pressed file, whereas preseed_ssh does more stuff like adding webfiles and adding preseed hooks. I take it you don't see that as a problem? Ian.