From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] tools/libxl new bitmap functions
Date: Fri, 3 Apr 2015 14:37:06 +0000
Message-ID: <1428071825.7917.26.camel@citrix.com>
References: <1427996296-27980-1-git-send-email-lindaj@jma3.com>
	<20150402193432.GJ3131@x230.dumpdata.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5552568686832427105=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150402193432.GJ3131@x230.dumpdata.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Julien Grall <julien.grall@citrix.com>, "lars.kurth@xen.org" <lars.kurth@xen.org>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "lindaj@jma3.com" <lindaj@jma3.com>
List-Id: xen-devel@lists.xenproject.org

--===============5552568686832427105==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-AlKwe1KkDhA6NgySRtue"

--=-AlKwe1KkDhA6NgySRtue
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-04-02 at 15:34 -0400, Konrad Rzeszutek Wilk wrote:
> On Thu, Apr 02, 2015 at 11:38:16AM -0600, Linda Jacobson wrote:
> > --- a/tools/libxl/libxl_utils.c
> > +++ b/tools/libxl/libxl_utils.c

> > +        goto out;
> > +    }
> > +
> > +    for (int bit =3D 0; bit < (size * 8); bit++)
>=20
> Please move the 'int bit' to the start of the function.
>=20
Or, even better, use libxl_for_each_bit, defined in libxl_utils.h. :-)

(I wanted to say this in my previous mail, while commenting about the
name of the functions and about the long lines, but forgot. :-D)

Regards,
Dario

--=-AlKwe1KkDhA6NgySRtue
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlUepZEACgkQk4XaBE3IOsTAbwCaA0YSnfMhCyi6/PKGP4BJofdR
vAkAnRnEtB0kPR9gDA/8YsDFAOykVK8f
=t4yN
-----END PGP SIGNATURE-----

--=-AlKwe1KkDhA6NgySRtue--


--===============5552568686832427105==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============5552568686832427105==--