From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Sat, 04 Apr 2015 00:32:40 +0000 Subject: Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c Message-Id: <1428107560.2775.2.camel@perches.com> List-Id: References: <1428106999-10067-1-git-send-email-andreasabu@gmail.com> In-Reply-To: <1428106999-10067-1-git-send-email-andreasabu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andreas Theodosiou Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, 2015-04-04 at 03:23 +0300, Andreas Theodosiou wrote: > This is a patch to the fb_ili9163.c file that inserts a line break in > line #92 to make the line fit into the 80 character limit. [] > diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c [] > @@ -89,7 +89,8 @@ > > /* > This display: > -http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271 > +http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI- > +Color-TFT-LCD-Display-Module-/271422122271 Please don't do this to links. There are many real defects to fix and other code to improve. This isn't one of those. I doubt though that an ebay link is very long lasting. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752582AbbDDAcr (ORCPT ); Fri, 3 Apr 2015 20:32:47 -0400 Received: from smtprelay0089.hostedemail.com ([216.40.44.89]:49723 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752056AbbDDAco (ORCPT ); Fri, 3 Apr 2015 20:32:44 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2561:2564:2682:2685:2828:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3351:3622:3865:3866:3867:3868:3870:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:8634:9025:9388:10004:10400:10848:11232:11257:11658:11896:11914:12043:12517:12519:12555:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: jump95_51bb106fc804d X-Filterd-Recvd-Size: 1735 Message-ID: <1428107560.2775.2.camel@perches.com> Subject: Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c From: Joe Perches To: Andreas Theodosiou Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Fri, 03 Apr 2015 17:32:40 -0700 In-Reply-To: <1428106999-10067-1-git-send-email-andreasabu@gmail.com> References: <1428106999-10067-1-git-send-email-andreasabu@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-04-04 at 03:23 +0300, Andreas Theodosiou wrote: > This is a patch to the fb_ili9163.c file that inserts a line break in > line #92 to make the line fit into the 80 character limit. [] > diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c [] > @@ -89,7 +89,8 @@ > > /* > This display: > -http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271 > +http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI- > +Color-TFT-LCD-Display-Module-/271422122271 Please don't do this to links. There are many real defects to fix and other code to improve. This isn't one of those. I doubt though that an ebay link is very long lasting.