diff for duplicates of <1428154411.20500.312.camel@kernel.crashing.org> diff --git a/a/1.txt b/N1/1.txt index 74b7337..5f650db 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -48,8 +48,8 @@ Basically the logic looks like that: .../... n = iommu_area_alloc(...) - if (n == -1) { - if (pass == 0) { + if (n = -1) { + if (pass = 0) { change pool hint pool->need_flush = true; pass++; @@ -77,14 +77,14 @@ Basically the logic looks like that: Now this can be further simplified imho. For example that logic: -+ if (pass == 0 && handle && *handle && ++ if (pass = 0 && handle && *handle && + (*handle >= pool->start) && (*handle < pool->end)) + start = *handle; + else + start = pool->hint; Can move above the again: label. that way, you remove the pass test -and you no longer have to adjust pool->hint in the "if (likely(pass == +and you no longer have to adjust pool->hint in the "if (likely(pass = 0))" failure case. Just adjust "start" and try again, which means you also no longer need to set need_flush. diff --git a/a/content_digest b/N1/content_digest index 308156c..53ca3de 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,8 +5,8 @@ "ref\01428095210.20500.291.camel@kernel.crashing.org\0" "ref\020150404112714.GA2117@oracle.com\0" "From\0Benjamin Herrenschmidt <benh@kernel.crashing.org>\0" - "Subject\0Re: [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock\0" - "Date\0Sun, 05 Apr 2015 00:33:31 +1100\0" + "Subject\0Re: [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l\0" + "Date\0Sat, 04 Apr 2015 13:33:31 +0000\0" "To\0Sowmini Varadhan <sowmini.varadhan@oracle.com>\0" "Cc\0aik@au1.ibm.com" anton@au1.ibm.com @@ -66,8 +66,8 @@ "\t.../...\n" "\n" "\tn = iommu_area_alloc(...)\n" - "\tif (n == -1) {\n" - "\t\tif (pass == 0) {\n" + "\tif (n = -1) {\n" + "\t\tif (pass = 0) {\n" "\t\t\tchange pool hint\n" "\t\t\tpool->need_flush = true;\n" "\t\t\tpass++;\n" @@ -95,14 +95,14 @@ "\n" "Now this can be further simplified imho. For example that logic:\n" "\n" - "+ if (pass == 0 && handle && *handle &&\n" + "+ if (pass = 0 && handle && *handle &&\n" "+ (*handle >= pool->start) && (*handle < pool->end))\n" "+ start = *handle;\n" "+ else\n" "+ start = pool->hint;\n" "\n" "Can move above the again: label. that way, you remove the pass test\n" - "and you no longer have to adjust pool->hint in the \"if (likely(pass ==\n" + "and you no longer have to adjust pool->hint in the \"if (likely(pass =\n" "0))\" failure case. Just adjust \"start\" and try again, which means you\n" "also no longer need to set need_flush.\n" "\n" @@ -125,4 +125,4 @@ "Cheers,\n" Ben. -3868bb3ab26ba6f688260c3637857793e7eca1e3a66e013a91d5aabc76f83c8e +c72d3d99b9abeb1497ccecac0dcd7d973ebe46c8b691cdffcdd7a61a0b1d5c46
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.