From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value
Date: Sat, 04 Apr 2015 08:52:21 -0700 [thread overview]
Message-ID: <1428162741.2775.41.camel@perches.com> (raw)
In-Reply-To: <20150404135818.GW10964@mwanda>
On Sat, 2015-04-04 at 16:58 +0300, Dan Carpenter wrote:
> On Sat, Apr 04, 2015 at 12:04:59AM +0300, Dan Carpenter wrote:
> > 1) It's more clear when read in English. "if not strcmp then" or
> > "if strcmp NOT EQUAL zero".
> Oops. I got that reversed. I meant "if strcmp then". Only serves to
> emphasize my point though. :)
When I read it I understood what you meant, but
I thought the point was everybody makes mistakes.
!strcmp to test equality is still pretty idiomatic.
!memcmp too.
cheers, Joe
next prev parent reply other threads:[~2015-04-04 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 16:42 [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value Amitoj Kaur Chawla
2015-04-03 16:51 ` Dan Carpenter
2015-04-03 17:01 ` Joe Perches
2015-04-03 21:04 ` Dan Carpenter
2015-04-04 13:58 ` Dan Carpenter
2015-04-04 15:52 ` Joe Perches [this message]
2015-04-03 17:03 ` Amitoj Kaur Chawla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428162741.2775.41.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.