All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wanpeng Li <wanpeng.li@linux.intel.com>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@arm.com>,
	linux-kernel@vger.kernel.org,
	Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: [PATCH 7/7] sched/rt: reschedule if stop/dl task slip in after pull operations
Date: Mon,  6 Apr 2015 16:53:19 +0800	[thread overview]
Message-ID: <1428310399-13489-7-git-send-email-wanpeng.li@linux.intel.com> (raw)
In-Reply-To: <1428310399-13489-1-git-send-email-wanpeng.li@linux.intel.com>

pull_rt_task() can drop (and re-acquire) rq->lock, this means a dl or stop task 
can slip in, in which case need to reschedule. This patch add the reschedule
when the scenario occurs.

Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
---
 kernel/sched/rt.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 575da76..cc973e8 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2136,7 +2136,14 @@ static void switched_from_rt(struct rq *rq, struct task_struct *p)
 	if (!task_on_rq_queued(p) || rq->rt.rt_nr_running)
 		return;
 
-	if (pull_rt_task(rq))
+	/*
+	 * pull_rt_task() can drop (and re-acquire) rq->lock; this
+	 * means a dl or stop task can slip in, in which case we need
+	 * to reschedule.
+	 */
+	if (pull_rt_task(rq) ||
+		(unlikely((rq->stop && task_on_rq_queued(rq->stop)) ||
+			rq->dl.dl_nr_running)))
 		resched_curr(rq);
 }
 
@@ -2197,6 +2204,16 @@ prio_changed_rt(struct rq *rq, struct task_struct *p, int oldprio)
 		 */
 		if (oldprio < p->prio)
 			pull_rt_task(rq);
+
+		/*
+		 * pull_rt_task() can drop (and re-acquire) rq->lock; this
+		 * means a dl or stop task can slip in, in which case we need
+		 * to reschedule.
+		 */
+		if (unlikely((rq->stop && task_on_rq_queued(rq->stop)) ||
+			rq->dl.dl_nr_running))
+			resched_curr(rq);
+
 		/*
 		 * If there's a higher priority task waiting to run
 		 * then reschedule. Note, the above pull_rt_task
-- 
1.9.1


  parent reply	other threads:[~2015-04-06  9:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06  8:53 [PATCH 1/7] sched/deadline: fix try to pull pinned dl tasks in pull algorithm Wanpeng Li
2015-04-06  8:53 ` [PATCH 2/7] sched/deadline: make init_sched_dl_class() __init Wanpeng Li
2015-04-07 13:48   ` Juri Lelli
2015-04-07 23:00     ` Wanpeng Li
2015-04-06  8:53 ` [PATCH 3/7] sched/deadline: reduce rq lock contention by eliminating locking of non-feasible target Wanpeng Li
2015-04-07 13:48   ` Juri Lelli
2015-04-07 22:57     ` Wanpeng Li
2015-04-06  8:53 ` [PATCH 4/7] sched/deadline: reschedule if stop task slip in after pull operations Wanpeng Li
2015-04-20 10:27   ` Juri Lelli
2015-04-20 22:59     ` Wanpeng Li
2015-04-20 23:02       ` Wanpeng Li
2015-04-21  8:22         ` Juri Lelli
2015-04-06  8:53 ` [PATCH 5/7] sched/deadline: drop duplicate init_sched_dl_class declaration Wanpeng Li
2015-04-08  8:47   ` Juri Lelli
2015-04-08  8:33     ` Wanpeng Li
2015-04-06  8:53 ` [PATCH 6/7] sched/deadline: depend on clearing throttled status in replenish_dl_entity Wanpeng Li
2015-04-21  8:16   ` Juri Lelli
2015-04-21  8:10     ` Wanpeng Li
2015-04-06  8:53 ` Wanpeng Li [this message]
2015-04-14 23:10 ` [PATCH 1/7] sched/deadline: fix try to pull pinned dl tasks in pull algorithm Wanpeng Li
2015-04-27  9:42 ` Wanpeng Li
2015-05-06  7:11   ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428310399-13489-7-git-send-email-wanpeng.li@linux.intel.com \
    --to=wanpeng.li@linux.intel.com \
    --cc=juri.lelli@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.