All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Move message tracepoints to their own header
Date: Tue, 07 Apr 2015 08:58:58 +0200	[thread overview]
Message-ID: <1428389938.1841.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20150406231357.2b8e452d@grimm.local.home>

On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote:
> Every tracing file must have its own TRACE_SYSTEM defined.

Oh, that requirement is new to me. I also have the same in iwlwifi, with
even more TRACE_SYSTEMs.

> The mac80211 tracepoint header broke this and add in the middle
> of the file had:
> 
>  #undef TRACE_SYSTEM
>  #define TRACE_SYSTEM mac80211_msg
> 
> Unfortunately, this broke new code in the ftrace infrastructure.
> Moving the mac80211_msg into its own trace file with its own
> TRACE_SYSTEM defined fixes the issue.



> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Looks fine to me.

Reviewed-by: Johannes Berg <johannes@sipsolutions.net>

I could merge through my tree but I guess you'll want to put it through
a different one to be able to change the code that depends on this move.

johannes


  reply	other threads:[~2015-04-07  6:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07  3:13 [PATCH] mac80211: Move message tracepoints to their own header Steven Rostedt
2015-04-07  6:58 ` Johannes Berg [this message]
2015-04-07 12:55   ` Steven Rostedt
2015-04-07 13:40     ` Johannes Berg
2015-04-07 14:21   ` Steven Rostedt
2015-04-07 14:28     ` Johannes Berg
2015-04-07 16:13     ` [PATCH] iwlwifi: Move each system " Steven Rostedt
2015-04-08  7:44       ` Johannes Berg
2015-04-12 17:37         ` Emmanuel Grumbach
2015-04-13  6:22           ` Emmanuel Grumbach
2015-04-13  8:17             ` Emmanuel Grumbach
2015-04-13 15:05               ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428389938.1841.1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.