From: Alexander Aring <alex.aring@gmail.com>
To: linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de, mkl@pengutronix.de,
Alexander Aring <alex.aring@gmail.com>
Subject: [PATCHv3 bluetooth-next 4/4] ieee802154: set aret handling according to 802.15.4
Date: Tue, 7 Apr 2015 13:49:53 +0200 [thread overview]
Message-ID: <1428407393-16005-5-git-send-email-alex.aring@gmail.com> (raw)
In-Reply-To: <1428407393-16005-1-git-send-email-alex.aring@gmail.com>
The 802.15.4 standard describes a max frame retries parameter 3 as
default. Currently this parameter affects only the transceivers which
supports automatic retransmission. This at the moment the at86rf230
driver, all other drivers which don't support setting of max frame
retries parameter we assume the 802.15.4 default now.
This change will introduce that the at86rf230 driver will go into ARET
mode (max frame retries parameter above or equal zero) per default.
If somebody experience that other nodes receives the same frame
three times repeatly, then your receiving node doesn't support AACK
handling for receiving. For all users they should set the max frame
retries parameter to "-1" which turns off the ARET mode and restore the
old behaviour.
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
net/ieee802154/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ieee802154/core.c b/net/ieee802154/core.c
index 7a107b0..619a220 100644
--- a/net/ieee802154/core.c
+++ b/net/ieee802154/core.c
@@ -221,8 +221,7 @@ cfg802154_reset_mac_pib(struct wpan_dev *wpan_dev)
wpan_dev->min_be = 3;
wpan_dev->max_be = 5;
wpan_dev->csma_retries = 4;
- /* for compatibility, actual default is 3 */
- wpan_dev->frame_retries = -1;
+ wpan_dev->frame_retries = 3;
wpan_dev->pan_id = cpu_to_le16(IEEE802154_PAN_ID_BROADCAST);
wpan_dev->short_addr = cpu_to_le16(IEEE802154_ADDR_SHORT_BROADCAST);
--
2.3.5
prev parent reply other threads:[~2015-04-07 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 11:49 [PATCHv3 bluetooth-next 0/4] ieee802154: nl802154 SET commands and pib defaults Alexander Aring
2015-04-07 11:49 ` [PATCHv3 bluetooth-next 1/4] nl802154: add set wpan phy cmd Alexander Aring
2015-04-07 11:49 ` [PATCHv3 bluetooth-next 2/4] nl802154: add set interface cmd Alexander Aring
2015-04-07 11:59 ` Phoebe Buckheister
2015-04-07 12:21 ` Alexander Aring
2015-04-07 12:29 ` Varka Bhadram
2015-04-07 13:14 ` Alexander Aring
2015-04-07 12:29 ` Phoebe Buckheister
2015-04-07 12:59 ` Alexander Aring
2015-04-07 13:02 ` Phoebe Buckheister
2015-04-07 13:25 ` Alexander Aring
2015-04-07 13:32 ` Phoebe Buckheister
2015-04-07 13:40 ` Alexander Aring
2015-04-07 11:49 ` [PATCHv3 bluetooth-next 3/4] ieee802154: move mac pib defaults Alexander Aring
2015-04-07 11:49 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428407393-16005-5-git-send-email-alex.aring@gmail.com \
--to=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.