From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Juri Lelli <juri.lelli@arm.com>, Borislav Petkov <bp@alien8.de>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Juri Lelli <juri.lelli@gmail.com>
Subject: Re: [PATCH] sched/core: Drop debugging leftover trace_printk call
Date: Tue, 07 Apr 2015 07:26:13 -0700 [thread overview]
Message-ID: <1428416773.20888.100.camel@perches.com> (raw)
In-Reply-To: <20150407101036.59f1427e@gandalf.local.home>
On Tue, 2015-04-07 at 10:10 -0400, Steven Rostedt wrote:
> On Tue, 07 Apr 2015 07:01:37 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > o Please add a test for $realfile !~ m@kernel/trace/@
> > or maybe $realfile !~ /(?:trace|tracing)/
> > o ERROR seems a bit strong, WARN is probably good enough
>
> I'm thinking ERROR is good. There's no reason to have it. In fact, you
> must never have it. Looking at the other ERROR() conditions, I say this
Look at trace_printk in fs/ext4/inline.c
It's in a section guarded by a CONFIG_FOO_DEBUG
block. Is the use there an error? Perhaps not
and I think it better if checkpatch ERROR messages
are more definitive.
> is just as strong and perhaps even stronger. You have ERROR() for
> trailing white space. This is much worse than that.
I'm not much of a fan of that one, nor of most
of the ERROR uses in checkpatch actually.
I think it might be better if all of the checkpatch
whitespace/style related messages were WARN not ERROR.
next prev parent reply other threads:[~2015-04-07 14:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 8:42 [PATCH] sched/core: Drop debugging leftover trace_printk call Borislav Petkov
2015-04-03 8:51 ` [tip:sched/core] " tip-bot for Borislav Petkov
2015-04-03 13:24 ` [PATCH] " Steven Rostedt
2015-04-03 13:28 ` Borislav Petkov
2015-04-07 13:47 ` Juri Lelli
2015-04-07 13:56 ` Steven Rostedt
2015-04-07 14:19 ` Juri Lelli
2015-04-07 14:01 ` Joe Perches
2015-04-07 14:10 ` Steven Rostedt
2015-04-07 14:26 ` Joe Perches [this message]
2015-04-07 14:34 ` Steven Rostedt
2015-04-07 14:38 ` Peter Zijlstra
2015-04-07 14:43 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428416773.20888.100.camel@perches.com \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=juri.lelli@arm.com \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.