From: "Jaggi, Manish" <Manish.Jaggi@caviumnetworks.com>
To: Julien Grall <julien.grall@linaro.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Issue With Patch Compilation Fails ( xen/arm: Introduce a generic way to describe device) with HAS_PCI and HAS_PASSTHROUGH.
Date: Tue, 7 Apr 2015 16:27:38 +0000 [thread overview]
Message-ID: <1428424057966.85266@caviumnetworks.com> (raw)
Hi Julien,
Following patch generated compiler error when HAS_PCI adn HAS_PASSTHROUGH enabled.
Please advice how to fix this issue, or you can revert this patch.
Should I add a device structure in pci_dev or there is another way.
----
xen/arm: Introduce a generic way to describe device
Currently, Xen is supporting PCI and Platform device (based on Device Tree).
While Xen only supports Platform device on ARM, Xen will gain support of
PCI soon.
Some drivers, such as IOMMU drivers, may handle PCI and platform device in
the same way. Only few lines of code differs.
Rather than requesting to provide 2 set of functions (one for PCI and
one for platform device), introduce a generic structure "device" which
is embedded in each specialized device.
As x86 only supports PCI, introduce a new type device_t which will be an
alias to pci_dev for this architecture. It will avoid to add a new field
for this place.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
CC: Keir Fraser <keir@xen.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
----
Compilation error
pci.c: In function ‘iommu_add_device’:
pci.c:1263:5: error: implicit declaration of function ‘pci_to_dev’ [-Werror=implicit-function-declaration]
pci.c:1263:5: error: nested extern declaration of ‘pci_to_dev’ [-Werror=nested-externs]
pci.c:1263:5: error: passing argument 2 of ‘hd->platform_ops->add_device’ makes pointer from integer without a cast [-Werror]
pci.c:1263:5: note: expected ‘struct device_t *’ but argument is of type ‘int’
pci.c:1272:9: error: passing argument 2 of ‘hd->platform_ops->add_device’ makes pointer from integer without a cast [-Werror]
pci.c:1272:9: note: expected ‘struct device_t *’ but argument is of type ‘int’
Regards,
Manish Jaggi
next reply other threads:[~2015-04-07 16:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 16:27 Jaggi, Manish [this message]
2015-04-07 16:43 ` Issue With Patch Compilation Fails ( xen/arm: Introduce a generic way to describe device) with HAS_PCI and HAS_PASSTHROUGH Stefano Stabellini
2015-04-08 5:35 ` Manish Jaggi
2015-04-08 6:54 ` Manish Jaggi
2015-04-08 9:23 ` Stefano Stabellini
2015-04-08 9:31 ` Manish Jaggi
2015-04-08 9:49 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428424057966.85266@caviumnetworks.com \
--to=manish.jaggi@caviumnetworks.com \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.