From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753663AbbDGQzg (ORCPT ); Tue, 7 Apr 2015 12:55:36 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:36159 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753129AbbDGQzf (ORCPT ); Tue, 7 Apr 2015 12:55:35 -0400 Message-ID: <1428425721.3160.5.camel@gmail.com> Subject: Re: [PATCH] sched/core: Remove wakeup_gran with single call calc_delta_fair From: Mike Galbraith To: Abel Vesa Cc: Peter Zijlstra , mingo@redhat.com, linux-kernel@vger.kernel.org Date: Tue, 07 Apr 2015 18:55:21 +0200 In-Reply-To: References: <1428345823-8491-1-git-send-email-abelvesa@gmail.com> <20150407103052.GL23123@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-04-07 at 16:37 +0300, Abel Vesa wrote: > On Tue, Apr 7, 2015 at 1:30 PM, Peter Zijlstra > wrote: > > On Mon, Apr 06, 2015 at 09:43:43PM +0300, Abel Vesa wrote: > > > This patch removes function wakeup_gran and its call by calling > > > directly > > > calc_delta_fair function with sysctl_sched_wakeup_granularity > > > and se as arguments. > > > > But why? > > I was thinking that maybe reducing another function call would be a > better idea. > I don't see what's the point of calling a 'wakeup_gran' just to > declare 'gran' as local variable and then > call calc_delta_fair instead of calling directly calc_delta_fair. > Plus, I think it seems more > readable to me. Of course, I might be wrong. I expected it be inlined by gcc, but that didn't happen with gcc-4.8.3. -Mike