All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Fleig <andreasfleig@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: set INPUT_PROP_POINTING_STICK in hid-lenovo
Date: Wed, 08 Apr 2015 11:34:30 +0200	[thread overview]
Message-ID: <1428485670.14997.0@smtp.gmail.com> (raw)
In-Reply-To: <CAKdAkRS=j4sOCDNVKzr7di2wh2XWDCF8ZC7sTXAa05NPdqJPmA@mail.gmail.com>

On Tue, Apr 7, 2015 at 5:42 , Dmitry Torokhov 
<dmitry.torokhov@gmail.com> wrote:
> Without commenting on validity of making this decision based on
> presence or absence of LEDs the proper test would be:
> 
>         if (!test_bit(EV_LED, hi->input->evbit)) {

Thanks, that's much cleaner. I'll also test for EV_REL instead, which 
makes more sense, especially since the keyboard doesn't actually have 
physical LEDs.

Andreas


      reply	other threads:[~2015-04-08  9:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07  9:32 [PATCH] Input: set INPUT_PROP_POINTING_STICK in hid-lenovo Andreas Fleig
2015-04-07 15:42 ` Dmitry Torokhov
2015-04-08  9:34   ` Andreas Fleig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428485670.14997.0@smtp.gmail.com \
    --to=andreasfleig@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.