From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 5/6] x86/smp: Allocate pcpu stacks on their
 local numa node
Date: Wed, 8 Apr 2015 10:16:00 +0000
Message-ID: <1428487601.5671.103.camel@citrix.com>
References: <1428427580-8854-1-git-send-email-andrew.cooper3@citrix.com>
	<1428427580-8854-6-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2246695853204857510=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1428427580-8854-6-git-send-email-andrew.cooper3@citrix.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, "JBeulich@suse.com" <JBeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============2246695853204857510==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-W44W1H3XqC/qx8IfY2qI"

--=-W44W1H3XqC/qx8IfY2qI
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2015-04-07 at 18:26 +0100, Andrew Cooper wrote:
> Previously, all pcpu stacks tended to be allocated on node 0.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
>=20
Again, FWIW:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Out of curiosity...

>  xen/arch/x86/smpboot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
> index a009e91..116c8f8 100644
> --- a/xen/arch/x86/smpboot.c
> +++ b/xen/arch/x86/smpboot.c
> @@ -642,7 +642,7 @@ static int cpu_smpboot_alloc(unsigned int cpu)
>      if ( node !=3D NUMA_NO_NODE )
>          memflags =3D MEMF_node(node);
> =20
> -    stack_base[cpu] =3D alloc_xenheap_pages(STACK_ORDER, 0);
> +    stack_base[cpu] =3D alloc_xenheap_pages(STACK_ORDER, memflags);
>
... I wonder how/why this was '0', while all the other were already
using MEMF_node(cpu_to_node)...

:-O

Regards,
Dario

--=-W44W1H3XqC/qx8IfY2qI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlUk/bIACgkQk4XaBE3IOsQRCgCfYgtUiN+Rc4BpK4AbP1KO5nG9
Wo0AoIO0pV789tPL2Mp2lwQBkapx5vkU
=6tWK
-----END PGP SIGNATURE-----

--=-W44W1H3XqC/qx8IfY2qI--


--===============2246695853204857510==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2246695853204857510==--