From: Abelardo Ricart III <aricart@memnix.com>
To: linux-kbuild@vger.kernel.org
Cc: mmarek@suse.cz
Subject: [PATCH RFC 1/1] Explicit check for existing X.509 module signing keypair
Date: Thu, 09 Apr 2015 17:51:30 -0400 [thread overview]
Message-ID: <1428616290.3787.22.camel@memnix.com> (raw)
The module-signing.txt documentation states that the kernel will use an existing
x.509 key pair for module signing should they exist in the root of the source tree.
However, user provided signing keys are overwritten during build if the last-modified
times on the key pair don't align with what make expects. This patch explicitly checks
for the existence of the signing key files, skipping key generation should they exist.
Signed-off-by: Abelardo Ricart III <aricart@memnix.com>
---
diff --git a/kernel/Makefile b/kernel/Makefile
index 1408b33..6b8f292 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -168,6 +168,9 @@ ifndef CONFIG_MODULE_SIG_HASH
$(error Could not determine digest type to use from kernel config)
endif
+ifneq ("$(wildcard $(srctree)/signing_key.priv)","")
+ifneq ("$(wildcard $(srctree)/signing_key.x509)","")
+$(warning *** X.509 module signing key pair not found in root of source tree ***)
signing_key.priv signing_key.x509: x509.genkey
@echo "###"
@echo "### Now generating an X.509 key pair to be used for signing modules."
@@ -184,6 +187,8 @@ signing_key.priv signing_key.x509: x509.genkey
@echo "###"
@echo "### Key pair generated."
@echo "###"
+endif
+endif
x509.genkey:
@echo Generating X.509 key generation config
next reply other threads:[~2015-04-09 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 21:51 Abelardo Ricart III [this message]
2015-04-09 22:22 ` [PATCH RFC 1/1] Explicit check for existing X.509 module signing keypair Abelardo Ricart III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428616290.3787.22.camel@memnix.com \
--to=aricart@memnix.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.