From: Pramod Gurav <gpramod@codeaurora.org>
To: linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, bryanh@codeaurora.org,
sboyd@codeaurora.org, jslaby@suse.cz,
Pramod Gurav <gpramod@codeaurora.org>
Subject: [PATCH v3 2/3] tty: serial: msm: Remove duplicate operations on clocks in startup/shutdown
Date: Fri, 10 Apr 2015 17:49:55 +0530 [thread overview]
Message-ID: <1428668396-6955-2-git-send-email-gpramod@codeaurora.org> (raw)
In-Reply-To: <1428668396-6955-1-git-send-email-gpramod@codeaurora.org>
clk_prepare_enable/clk_disable_unprepare is already done in .pm
function of uart_ops hence get rid of them from msm_startup and
msm_shutdown.
Signed-off-by: Pramod Gurav <gpramod@codeaurora.org>
---
Changes since last version:
- Decided to drop calls to clk operations
drivers/tty/serial/msm_serial.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 99aba04..c32b088 100644
--- a/drivers/tty/serial/msm_serial.c
+++ b/drivers/tty/serial/msm_serial.c
@@ -494,8 +494,6 @@ static int msm_startup(struct uart_port *port)
if (unlikely(ret))
return ret;
- msm_init_clock(port);
-
if (likely(port->fifosize > 12))
rfr_level = port->fifosize - 12;
else
@@ -525,8 +523,6 @@ static void msm_shutdown(struct uart_port *port)
msm_port->imr = 0;
msm_write(port, 0, UART_IMR); /* disable interrupts */
- clk_disable_unprepare(msm_port->clk);
-
free_irq(port->irq, port);
}
@@ -683,8 +679,7 @@ static void msm_power(struct uart_port *port, unsigned int state,
switch (state) {
case 0:
- clk_prepare_enable(msm_port->clk);
- clk_prepare_enable(msm_port->pclk);
+ msm_init_clock(port);
break;
case 3:
clk_disable_unprepare(msm_port->clk);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-04-10 12:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 12:19 [PATCH v3 1/3] tty: serial: msm: Add mask value for UART_DM registers Pramod Gurav
2015-04-10 12:19 ` Pramod Gurav [this message]
2015-04-10 18:03 ` [PATCH v3 2/3] tty: serial: msm: Remove duplicate operations on clocks in startup/shutdown Stephen Boyd
2015-04-29 15:45 ` Pramod Gurav
2015-05-07 23:34 ` Stephen Boyd
2015-04-10 12:19 ` [PATCH v3 3/3] tty: serial: msm: replaces (1 << x) with BIT(x) macro Pramod Gurav
2015-04-10 12:33 ` Fabio Estevam
2015-05-07 23:37 ` Stephen Boyd
2015-04-10 17:57 ` [PATCH v3 1/3] tty: serial: msm: Add mask value for UART_DM registers Stephen Boyd
2015-04-28 11:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428668396-6955-2-git-send-email-gpramod@codeaurora.org \
--to=gpramod@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.