From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier =?ISO-8859-1?Q?Cr=EAte?= Subject: Re: libva decoding performance regression with kernel 4.0-rc Date: Fri, 10 Apr 2015 19:25:59 -0400 Message-ID: <1428708359.3417.39.camel@collabora.com> References: <1428627643.3417.22.camel@collabora.com> <20150410062331.GE20904@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150410062331.GE20904@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org SGVsbG8sCgpUaGFua3MgZm9yIHRoZSBxdWljayByZXBseSEKCldpdGggbXkgcmVhbCB1c2UtY2Fz ZXM6CgoxLiA5eCA3MjBwNjAgbXBlZzIgdmlkZW9zCiAtIDQuMC1yYzY6IH4xMiBmcmFtZXMgcGVy IHNlY29uZCBhcmUgb24gdGltZQogLSA0LjAtcmM2ICsgcmV2ZXJ0czogYSBzdGFibGUgNDUgZnJh bWVzIHBlciBzZWNvbmQgYXJlIG9uIHRpbWUKIC0gMDQ0MzA3YTk6IDQwLTQ1IGZyYW1lcyBwZXIg c2Vjb25kIGFyZSBvbiB0aW1lCiAtIDBhMjQ4MDJhOiA0NS00NiBmcmFtZXMgcGVyIHNlY29uZCBh cmUgb24gdGltZQoKMi4gMTA4MGkzMCBtcGVnMiB2aWRlb3MKIC0gNC4wLXJjNjogIDUgdmlkZW9z CiAtIDA0NDMwN2E5OiAxMCB2aWRlb3MKIC0gMGEyNDgwMmE6IDEwIHZpZGVvcwoKU28geW91IGJh c2ljYWxseSBiZWF0IG15IGJhc2VsaW5lIHRvbywgZ29vZCBqb2IsIHRoYW5rcyBhIGxvdCEgQW55 CmNoYW5jZSB5b3UgY2FuIHNuZWFrIHRoaXMgaW50byA0LjAgPwoKT2xpdmllcgoKT24gRnJpLCAy MDE1LTA0LTEwIGF0IDA3OjIzICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gVGh1LCBB cHIgMDksIDIwMTUgYXQgMDk6MDA6NDNQTSAtMDQwMCwgT2xpdmllciBDcsOqdGUgd3JvdGU6Cj4g PiBIZWxsbywKPiA+IAo+ID4gVXNpbmcgYW4gQXRvbSBFMzg0NSBib2FyZCwgd2UgaGFkIGEgcHJl dHR5IGJhZCBwZXJmb3JtYW5jZSByZWdyZXNzaW9uCj4gPiB3aGVuIHVwZ3JhZGluZyB0byA0LjAt cmM2IGZyb20gMy4xOS4gV2l0aCB0aGUgaGVscCBvZiBnaXQgYmlzZWN0LCBJCj4gPiB0cmFjZWQg aXQgYmFjayB0byBjb21taXQgNzhhNDIzNzcuIFJldmVydGluZyB0aGlzIGNvbW1pdCBhbmQgc3Vi c2VxdWVudAo+ID4gcmVsYXRlZCBjb21taXRzIChiOWZmZDgwLCA3MTc0NTM3NiwgZXRjKSBmaXhl cyB0aGUgcGVyZm9ybWFuY2UKPiA+IHJlZ3Jlc3Npb24gZm9yIG1lLgo+IAo+IENhbiB5b3UgcGxl YXNlIHRlc3QKPiAKPiBodHRwOi8vY2dpdC5mcmVlZGVza3RvcC5vcmcvfmlja2xlL2xpbnV4LTIu Ni9sb2cvP2g9Zm9yLW9saXZpZXItY3JldGUKPiAKPiBvbiB5b3VyIHNldHVwLgo+IAo+IEZpcnN0 Cj4gaHR0cDovL2NnaXQuZnJlZWRlc2t0b3Aub3JnL35pY2tsZS9saW51eC0yLjYvY29tbWl0Lz9o PWZvci1vbGl2aWVyLWNyZXRlJmlkPTA0NDMwN2E5OWI0MTgyNThhYzBkNzc1NDYwZDczYjIwYjgw Mjc3YzEKPiB0byBnZXQgYSBiYXNlbGluZSB3aXRoIG5pZ2h0bHkgYXMgdGhhdCBjb250YWlucyBz b21lIGZpbmUgdHVuaW5nIHRvIHRoZQo+IGJhdGNoIGFsbG9jYXRpb25zLCB3aGljaCBpcyBwcmV0 dHkgc2lnbmlmaWNhbnQgZm9yIGxpYnZhIG9uIEF0b20gKG9ubHkKPiBkb3VibGUgY2xmbHVzaGlu ZyBvbmUgb3IgdHdvIHBhZ2VzIGV2ZXJ5IGJhdGNoIHJhdGhlciB0aGFuIDEyOCkgYW5kIHRoZW4K PiBodHRwOi8vY2dpdC5mcmVlZGVza3RvcC5vcmcvfmlja2xlL2xpbnV4LTIuNi9jb21taXQvP2g9 Zm9yLW9saXZpZXItY3JldGUmaWQ9MGEyNDgwMmE1YjYxNDAzYjg4N2NlNDAxY2UzZWZkNTJmNWZk MWVhYwo+IHRvIHNlZSBpZiB0aGUgY29tbWFuZCBwYXJzZXIgdHVuaW5nIGhlbHBzLgo+IAo+IEhv cGUgdGhpcyBoZWxwcywKPiAtQ2hyaXMKPiAKCi0tIApPbGl2aWVyIENyw6p0ZQpvbGl2aWVyLmNy ZXRlQGNvbGxhYm9yYS5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932677AbbDJX0K (ORCPT ); Fri, 10 Apr 2015 19:26:10 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:58542 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbbDJX0F (ORCPT ); Fri, 10 Apr 2015 19:26:05 -0400 Message-ID: <1428708359.3417.39.camel@collabora.com> Subject: Re: libva decoding performance regression with kernel 4.0-rc From: Olivier =?ISO-8859-1?Q?Cr=EAte?= To: Chris Wilson Cc: Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Fri, 10 Apr 2015 19:25:59 -0400 In-Reply-To: <20150410062331.GE20904@nuc-i3427.alporthouse.com> References: <1428627643.3417.22.camel@collabora.com> <20150410062331.GE20904@nuc-i3427.alporthouse.com> Organization: Collabora Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Thanks for the quick reply! With my real use-cases: 1. 9x 720p60 mpeg2 videos - 4.0-rc6: ~12 frames per second are on time - 4.0-rc6 + reverts: a stable 45 frames per second are on time - 044307a9: 40-45 frames per second are on time - 0a24802a: 45-46 frames per second are on time 2. 1080i30 mpeg2 videos - 4.0-rc6: 5 videos - 044307a9: 10 videos - 0a24802a: 10 videos So you basically beat my baseline too, good job, thanks a lot! Any chance you can sneak this into 4.0 ? Olivier On Fri, 2015-04-10 at 07:23 +0100, Chris Wilson wrote: > On Thu, Apr 09, 2015 at 09:00:43PM -0400, Olivier Crête wrote: > > Hello, > > > > Using an Atom E3845 board, we had a pretty bad performance regression > > when upgrading to 4.0-rc6 from 3.19. With the help of git bisect, I > > traced it back to commit 78a42377. Reverting this commit and subsequent > > related commits (b9ffd80, 71745376, etc) fixes the performance > > regression for me. > > Can you please test > > http://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=for-olivier-crete > > on your setup. > > First > http://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=for-olivier-crete&id=044307a99b418258ac0d775460d73b20b80277c1 > to get a baseline with nightly as that contains some fine tuning to the > batch allocations, which is pretty significant for libva on Atom (only > double clflushing one or two pages every batch rather than 128) and then > http://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=for-olivier-crete&id=0a24802a5b61403b887ce401ce3efd52f5fd1eac > to see if the command parser tuning helps. > > Hope this helps, > -Chris > -- Olivier Crête olivier.crete@collabora.com