From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755241AbbDKRUs (ORCPT ); Sat, 11 Apr 2015 13:20:48 -0400 Received: from smtprelay0242.hostedemail.com ([216.40.44.242]:39723 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754058AbbDKRUn (ORCPT ); Sat, 11 Apr 2015 13:20:43 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:4250:4321:5007:6119:6261:7901:7903:8957:10004:10400:10471:10848:11026:11232:11473:11658:11914:12296:12438:12517:12519:12740:13069:13161:13229:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: tank87_7a55e669bf12f X-Filterd-Recvd-Size: 2335 Message-ID: <1428772838.5413.58.camel@perches.com> Subject: Re: [PATCH] drivers/usb/core: devio.c: Removed various errors and warnings generated by checkpatch.pl From: Joe Perches To: Chase Metzger Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, hdegoede@redhat.com, oneukum@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 11 Apr 2015 10:20:38 -0700 In-Reply-To: <1428738815-15373-1-git-send-email-chasemetzger15@gmail.com> References: <1428738815-15373-1-git-send-email-chasemetzger15@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-04-11 at 00:53 -0700, Chase Metzger wrote: > Fixed several errors and warnings. [] > Lines 1040 and 1591: changed dev_printk(KERN_DEBUG, ...) to dev_dbg(...). These changes hav the possibly undesired effect of removing these messages completely when DEBUG is not #defined or when CONFIG_DYNAMIC_DEBUG is not enabled and these messages are not specifically enabled. > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c [] > @@ -1040,7 +1040,7 @@ static int proc_control(struct usb_dev_state *ps, void __user *arg) > snoop_urb(dev, NULL, pipe, max(i, 0), min(i, 0), COMPLETE, NULL, 0); > } > if (i < 0 && i != -EPIPE) { > - dev_printk(KERN_DEBUG, &dev->dev, "usbfs: USBDEVFS_CONTROL " > + dev_dbg(&dev->dev, "usbfs: USBDEVFS_CONTROL " > "failed cmd %s rqt %u rq %u len %u ret %d\n", > current->comm, ctrl.bRequestType, ctrl.bRequest, > ctrl.wLength, i); [] > @@ -1591,8 +1591,7 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb > } > > if (ret) { > - dev_printk(KERN_DEBUG, &ps->dev->dev, > - "usbfs: usb_submit_urb returned %d\n", ret); > + dev_dbg(&ps->dev->dev, "usbfs: usb_submit_urb returned %d\n", ret); > snoop_urb(ps->dev, as->userurb, as->urb->pipe, > 0, ret, COMPLETE, NULL, 0); > async_removepending(as);