All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Poehn <sebastian.poehn@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Sebastian Poehn <sebastian.poehn@gmail.com>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, fw@strlen.de, eric.dumazet@gmail.com
Subject: Re: [PATCH] ip_forward: Drop frames with attached skb->sk
Date: Tue, 14 Apr 2015 08:18:40 +0200	[thread overview]
Message-ID: <1428992320.6812.20.camel@googlemail.com> (raw)
In-Reply-To: <20150413230714.2cf40794@urahara>

On Mon, 2015-04-13 at 23:07 -0700, Stephen Hemminger wrote:
> On Tue, 14 Apr 2015 07:52:04 +0200
> Sebastian Poehn <sebastian.poehn@gmail.com> wrote:
> 
> >  
> > +	/* this should happen neither */
> > +	if (unlikely(skb->sk))
> > +		goto drop;
> > +
> 
> With gcc, all goto's are already treated as unlikely().

Thanks for that recommendation. But before I re-cook: What about Clang
and ICC?

  reply	other threads:[~2015-04-14  6:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  5:52 [PATCH] ip_forward: Drop frames with attached skb->sk Sebastian Poehn
2015-04-14  6:07 ` Stephen Hemminger
2015-04-14  6:18   ` Sebastian Poehn [this message]
2015-04-14 16:50     ` David Miller
2015-04-14  6:33 ` yzhu1
2015-04-14  6:40   ` Sebastian Poehn
2015-04-14 11:54     ` Eric Dumazet
2015-04-14 18:23       ` David Miller
2015-04-15  7:32         ` Sebastian Poehn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428992320.6812.20.camel@googlemail.com \
    --to=sebastian.poehn@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.