All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4] mtd: nand: mxs: Add comment for calculating ECC strength
Date: Tue, 14 Apr 2015 08:29:11 +0200	[thread overview]
Message-ID: <1428992951.2266.6.camel@embedded.rocks> (raw)
In-Reply-To: <552CAFE5.409@denx.de>

Hello Heiko,

On Di, 2015-04-14 at 08:12 +0200, Heiko Schocher wrote:
> Hello J?rg,
> 
> Am 13.04.2015 22:17, schrieb J?rg Krause:
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > ---
> >   drivers/mtd/nand/mxs_nand.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> 
> nitpick only ...

I'm unsure what this comment means translated to German. Something
like small changes only?

> 
> > diff --git a/drivers/mtd/nand/mxs_nand.c 
> > b/drivers/mtd/nand/mxs_nand.c
> > index 912fed8..76e47ab 100644
> > --- a/drivers/mtd/nand/mxs_nand.c
> > +++ b/drivers/mtd/nand/mxs_nand.c
> > @@ -148,6 +148,13 @@ static inline uint32_t 
> > mxs_nand_get_ecc_strength(uint32_t page_data_size,
> >   {
> >     int ecc_strength;
> > 
> > +   /* Determine the ECC layout with the formula:
> 
> wrong comment style ... please fix also in patch 4/4... thanks.

Checkpatch did not complain and I did not know there is a coding style
for comments. Should it be:
    /*
     * Determine the ECC layout...

Bye
J?rg

  reply	other threads:[~2015-04-14  6:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 20:17 [U-Boot] [PATCH v2 0/4] mtd: nand: mxs: Calculate ECC strength dynamically Jörg Krause
2015-04-13 20:17 ` [U-Boot] [PATCH v2 1/4] mtd:mxs:nand calculate ecc " Jörg Krause
2015-04-13 20:17 ` [U-Boot] [PATCH v2 2/4] mtd: nand: mxs: Replace magic number for bits per ECC level with macro Jörg Krause
2015-04-13 20:17 ` [U-Boot] [PATCH v2 3/4] mtd: nand: mxs: Add comment for calculating ECC strength Jörg Krause
2015-04-14  6:12   ` Heiko Schocher
2015-04-14  6:29     ` Jörg Krause [this message]
2015-04-14  8:02       ` Heiko Schocher
2015-04-14 15:32         ` Jörg Krause
2015-04-15  5:39           ` Heiko Schocher
2015-04-13 20:17 ` [U-Boot] [PATCH v2 4/4] tools: mxsboot: Calculate ECC strength dynamically Jörg Krause
2015-04-14  6:11 ` [U-Boot] [PATCH v2 0/4] mtd: nand: mxs: " Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428992951.2266.6.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.