All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian-Ken Rueegsegger <ken@codelabs.ch>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Adrian-Ken Rueegsegger <ken@codelabs.ch>
Subject: [PATCH] genirq: Only call irq_ack if implemented by chip
Date: Tue, 14 Apr 2015 12:29:07 +0200	[thread overview]
Message-ID: <1429007347-7167-1-git-send-email-ken@codelabs.ch> (raw)

Restore the check if an IRQ chip implements the irq_ack function prior
to its invocation. Commit 22a49163e90d ("genirq: Provide compat handling
for chip->ack()") removed the check from handle_edge_irq while keeping
the check in other call paths.

Signed-off-by: Adrian-Ken Rueegsegger <ken@codelabs.ch>
---
 kernel/irq/chip.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index eb9a4ea..3889b02 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -586,7 +586,8 @@ handle_edge_irq(unsigned int irq, struct irq_desc *desc)
 	kstat_incr_irqs_this_cpu(irq, desc);
 
 	/* Start handling the irq */
-	desc->irq_data.chip->irq_ack(&desc->irq_data);
+	if (desc->irq_data.chip->irq_ack)
+		desc->irq_data.chip->irq_ack(&desc->irq_data);
 
 	do {
 		if (unlikely(!desc->action)) {
-- 
1.7.10.4


             reply	other threads:[~2015-04-14 10:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14 10:29 Adrian-Ken Rueegsegger [this message]
2015-04-14 18:00 ` [PATCH] genirq: Only call irq_ack if implemented by chip Thomas Gleixner
2015-04-15  9:40   ` Adrian-Ken Rueegsegger
2015-04-21 12:20     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429007347-7167-1-git-send-email-ken@codelabs.ch \
    --to=ken@codelabs.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.