From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V8 00/12] xen: Clean-up of mem_event subsystem Date: Tue, 14 Apr 2015 12:31:51 +0100 Message-ID: <1429011111.15516.37.camel@citrix.com> References: <1427404024-30567-1-git-send-email-tamas.lengyel@zentific.com> <20150409110318.GB17025@deinos.phlegethon.org> <20150409113020.GC17025@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150409113020.GC17025@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: Kevin Tian , Keir Fraser , Jun Nakajima , Steven Maresca , Stefano Stabellini , Tamas Lengyel , Ian Jackson , Xen-devel , Eddie Dong , Andres Lagar Cavilla , Jan Beulich , "rshriram@cs.ubc.ca" , "wei.liu2@citrix.com" , Daniel De Graaf , "yanghy@cn.fujitsu.com" , Razvan Cojocaru List-Id: xen-devel@lists.xenproject.org On Thu, 2015-04-09 at 12:30 +0100, Tim Deegan wrote: > > What's the policy on reusing DOMCTL numbers? I see > > XEN_DOMCTL_arm_configure_domain > > has been retired in the conflicting patch. Should I just reuse it's number > > for monitor_op? For the most part domctl numbers seem to be continuous but > > there are holes (30-32) so I'm not sure. > > I'm not sure either. I'd be inlclined to leave a hole here, to avoid > any accidental confusion with the recently-removed op, but other > maintainers may disagree. :) I also think we should leave a hole. And perhaps we should have left a "previous used as" type comment when removing arm_configure_domain, sorry for not thinking of that at the time... Ian.