Re: [PATCH v9 13/15] tools/libxc: noarch restore code

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-04-15 at 12:50 +0100, Andrew Cooper wrote:
> On 15/04/15 12:42, Ian Campbell wrote:
> > On Fri, 2015-04-10 at 18:16 +0100, Andrew Cooper wrote:
> >> +/**
> >> + * Reads a record from the stream, and fills in the record structure.
> > Doesn't look to be a structured comment of any sort, so only one *
> > needed on the opening.
> >
> >> + * Given a list of pfns, their types, and a block of page data from the
> >> + * stream, populate and record their types, map the relevent subset and copy
> > relevant.
> >
> > With those two nits addressed:
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >> +    for ( i = 0; i < count; ++i )
> >> +    {
> >> +        ctx->restore.ops.set_page_type(ctx, pfns[i], types[i]);
> >> +
> >> +        switch ( types[i] )
> >> +        {
> >> +        case XEN_DOMCTL_PFINFO_NOTAB:
> > For my own enlightenment:
> >
> > What is in a NOTAB page and is it correct to uncanonicalise it?
> 
> Notab is a regular plain ram page.  I think the name refers to "not a
> pagetable".
> 
> This loop is working out which guest frames to map, so data can be
> memcpy()'d in.  It is a larger set than the pages which subsequently get
> uncanonicalised.

Ah, for some reason I thought we were doing the uncanon here, but I see
now we aren't, thanks!