From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v6 4/5] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc Date: Wed, 15 Apr 2015 13:33:15 +0100 Message-ID: <1429101195.15516.257.camel@citrix.com> References: <1428358329-8466-1-git-send-email-boris.ostrovsky@oracle.com> <1428358329-8466-5-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1428358329-8466-5-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: elena.ufimtseva@oracle.com, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, keir@xen.org, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On Mon, 2015-04-06 at 18:12 -0400, Boris Ostrovsky wrote: > xc_numainfo() is not expected to be used on a hot path and therefore > hypercall buffer management can be pushed into libxc. This will simplify > life for callers. > > Also update error logging macros. > > Signed-off-by: Boris Ostrovsky > --- > > Changes in v6: > * Dropped separate NULL buffer tests in xc_numainfo() > * Moved test for buffers validity (either both or neither are NULL) to be the > the first thing to do in xc_numainfo() I suppose this last bit will be impacted by the discussion on #1? In any case as long as this check ends up matching the hypercall semantics, as to be agreed with the hypervisor maintainers, then you may add my: Acked-by: Ian Campbell