From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 3/7] libxl/libxl_domain_info: Log if domain not found. Date: Wed, 15 Apr 2015 14:03:23 +0100 Message-ID: <1429103003.15516.272.camel@citrix.com> References: <1428091354-6720-1-git-send-email-konrad.wilk@oracle.com> <1428091354-6720-4-git-send-email-konrad.wilk@oracle.com> <551F103F.2000209@yahoo.co.uk> <20150406133202.GB12596@l.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150406133202.GB12596@l.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Ian Murray , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-04-06 at 09:32 -0400, Konrad Rzeszutek Wilk wrote: > Ian C, thoughts? Just ditch this patch? I think so, my original suggestion to include the logging was predicated on it not being usual for us to look up a non-existent domid, but the xl domid usecase was one which didn't occur, and is a very valid reason not to do this. Alternatively could crank the log level all the way down to DEBUG, I'm happy either way (at least until someone tells me why I'm not!). Ian